Skip to content

Update Jackson to 2.18.4 #8449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
piotrp wants to merge 3 commits into
base: staging
Choose a base branch
from
Open

Update Jackson to 2.18.4 #8449

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
32e28d1
Update Jackson to 2.18.4
piotrp Aug 4, 2025
27c3b5c
docs
piotrp Aug 4, 2025
c7e808e
workaround for schemaForPlain, still hacky but simple
piotrp Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ val circeV = "0.14.14"
val circeGenericExtrasV = "0.14.4"
val circeYamlV = "0.15.2" // 0.15.3 drops Scala 2.12
val jwtCirceV = "11.0.2"
val jacksonV = "2.18.2" // 2.18.3+ breaks ContentTypesSchemas.schemaForPlain
Comment thread
lciolecki marked this conversation as resolved.
Outdated
val jacksonV = "2.18.4"
val catsV = "2.13.0"
val catsEffectV = "3.5.7"
val everitSchemaV = "1.14.5"
Expand Down
4 changes: 2 additions & 2 deletions docs/Changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,13 +277,13 @@ description: Stay informed with detailed changelogs covering new features, impro
}
}
```
* [#8352](https://github.com/TouK/nussknacker/pull/8352) Updated dependencies:
* [#8352](https://github.com/TouK/nussknacker/pull/8352)[#8449](https://github.com/TouK/nussknacker/pull/8449) Updated dependencies:
* Caffeine Cache 3.1.8 -> 3.2.1
* Cats Effect 3.5.4 -> 3.5.7
* Cats 2.12.0 -> 2.13.0
* Circe 0.14.10 -> 0.14.14
* HikariCP 6.2.1 -> 6.3.1
* Jackson 2.17.2 -> 2.18.2
* Jackson 2.17.2 -> 2.18.4
* Netty 4.1.119.Final -> 4.1.123.Final
* PostgreSQL JDBC driver 42.7.4 -> 42.7.7
* sttp 3.9.8 -> 3.11.0
Expand Down
6 changes: 2 additions & 4 deletions .../src/main/scala/pl/touk/nussknacker/engine/schemedkafka/schemaregistry/ContentTypes.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ object ContentTypes extends Enumeration {
}

object ContentTypesSchemas {
val schemaForJson: OpenAPIJsonSchema = OpenAPIJsonSchema("{}")
// note: "" deserializes to com.fasterxml.jackson.databind.node.MissingNode,
// which causes NPE when using Jackson 2.18.3+, because from this version on it decodes to null
val schemaForPlain: OpenAPIJsonSchema = OpenAPIJsonSchema("")
val schemaForJson: OpenAPIJsonSchema = OpenAPIJsonSchema("{}")

@lciolecki lciolecki Aug 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, do we even need these two schemas?

@piotrp piotrp Aug 4, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, yes:

class UniversalSchemaSupportDispatcher private (kafkaConfig: KafkaConfig) {
...
  def forParsedSchema(parsedSchema: ParsedSchema): UniversalSchemaSupport = parsedSchema match {
    // For ad hoc tests we want to present the user with json editor when topic has no schema and content type Json was selected
    case ContentTypesSchemas.schemaForJson => NoSchemaJsonSupport
    case _                                 => forSchemaType(parsedSchema.schemaType())
  }

val schemaForPlain: OpenAPIJsonSchema = OpenAPIJsonSchema("{}")
}
Loading