Skip to content

Changed ghost/admin (Ember) to ESLint 9 / flat config #28808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
9larsons wants to merge 1 commit into
base: main
Choose a base branch
from
+1,011 −392
Open

Changed ghost/admin (Ember) to ESLint 9 / flat config #28808

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 0 additions & 70 deletions ghost/admin/.eslintrc.js
View file
Open in desktop

This file was deleted.

227 changes: 227 additions & 0 deletions ghost/admin/eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,227 @@
import path from 'node:path';
import js from '@eslint/js';
import globals from 'globals';
import babelParser from '@babel/eslint-parser';
import ghostPlugin from 'eslint-plugin-ghost';
import emberPlugin from 'eslint-plugin-ember';
import reactPlugin from 'eslint-plugin-react';

// eslint-plugin-filenames-ts@1.3.2's match-regex calls context.getScope(),
// which ESLint 9 removed. Replace it with a minimal equivalent.
const filenamesMatchRegex = {
meta: {
type: 'problem',
schema: [
{type: 'string'},
{type: ['boolean', 'null']},
{type: ['boolean', 'null']}
]
},
create(context) {
const pattern = new RegExp(context.options[0]);
return {
Program(node) {
const filename = path.parse(context.filename).name;
if (!pattern.test(filename)) {
context.report({
node,
message: `Filename '${filename}' does not match the naming convention.`
});
}
}
};
}
};

const localFilenamesPlugin = {
rules: {'match-regex': filenamesMatchRegex}
};

const ghostBaseRules = {
curly: 'error',
camelcase: ['error', {properties: 'never'}],
'dot-notation': 'error',
eqeqeq: ['error', 'always'],
'no-plusplus': ['error', {allowForLoopAfterthoughts: true}],
'no-eval': 'error',
'no-useless-call': 'error',
'no-console': 'error',
'no-shadow': 'error',
'array-callback-return': 'error',
'no-constructor-return': 'error',
'no-promise-executor-return': 'error',
'no-unused-vars': ['error', {caughtErrors: 'none'}],
'no-unused-private-class-members': 'off'
};

const emberRules = {
'ghost/sort-imports-es6-autofix/sort-imports-es6': ['error', {
memberSyntaxSortOrder: ['none', 'all', 'single', 'multiple']
}],
// Components
'ghost/ember/no-attrs-in-components': 'error',
'ghost/ember/no-attrs-snapshot': 'error',
'ghost/ember/no-on-calls-in-components': 'error',
// Computed Properties
'ghost/ember/no-arrow-function-computed-properties': 'error',
'ghost/ember/no-computed-properties-in-native-classes': 'error',
'ghost/ember/no-deeply-nested-dependent-keys-with-each': 'error',
'ghost/ember/no-duplicate-dependent-keys': 'error',
'ghost/ember/no-incorrect-computed-macros': 'error',
'ghost/ember/no-invalid-dependent-keys': 'error',
'ghost/ember/no-side-effects': 'error',
'ghost/ember/no-volatile-computed-properties': 'error',
'ghost/ember/require-computed-macros': 'error',
'ghost/ember/require-return-from-computed': 'error',
'ghost/ember/use-brace-expansion': 'error',
// Controllers
'ghost/ember/alias-model-in-controller': 'error',
'ghost/ember/avoid-using-needs-in-controllers': 'error',
// Deprecations
'ghost/ember/closure-actions': 'error',
'ghost/ember/new-module-imports': 'error',
'ghost/ember/no-function-prototype-extensions': 'error',
'ghost/ember/no-observers': 'error',
'ghost/ember/no-old-shims': 'error',
'ghost/ember/no-string-prototype-extensions': 'error',
// Ember Data
'ghost/ember/use-ember-data-rfc-395-imports': 'error',
// Ember Object
'ghost/ember/avoid-leaking-state-in-ember-objects': 'error',
'ghost/ember/no-get-with-default': 'error',
'ghost/ember/no-try-invoke': 'error',
'ghost/ember/require-super-in-lifecycle-hooks': 'error',
// Octane
'ghost/ember/classic-decorator-hooks': 'error',
'ghost/ember/classic-decorator-no-classic-methods': 'error',
'ghost/ember/no-ember-super-in-es-classes': 'error',
'ghost/ember/no-empty-glimmer-component-classes': 'error',
// jQuery
'ghost/ember/jquery-ember-run': 'error',
'ghost/ember/no-global-jquery': 'error',
// Misc
'ghost/ember/no-incorrect-calls-with-inline-anonymous-functions': 'error',
'ghost/ember/no-invalid-debug-function-arguments': 'error',
'ghost/ember/require-fetch-import': 'error',
// Routes
'ghost/ember/no-capital-letters-in-routes': 'error',
'ghost/ember/no-private-routing-service': 'error',
'ghost/ember/no-shadow-route-definition': 'error',
'ghost/ember/no-unnecessary-index-route': 'error',
'ghost/ember/no-unnecessary-route-path-option': 'error',
'ghost/ember/route-path-style': 'error',
'ghost/ember/routes-segments-snake-case': 'error',
// Services
'ghost/ember/no-unnecessary-service-injection-argument': 'error',
// Stylistic
'ghost/ember/order-in-components': 'error',
'ghost/ember/order-in-controllers': 'error',
'ghost/ember/order-in-routes': 'error',
// Testing
'ghost/ember/no-ember-testing-in-module-scope': 'error',
'ghost/ember/no-invalid-test-waiters': 'error',
'ghost/ember/no-legacy-test-waiters': 'error',
'ghost/ember/no-noop-setup-on-error-in-before': 'error',
'ghost/ember/no-pause-test': 'error',
'ghost/ember/no-replace-test-comments': 'error',
'ghost/ember/no-restricted-resolver-tests': 'error',
'ghost/ember/no-settled-after-test-helper': 'error',
'ghost/ember/no-test-and-then': 'error',
'ghost/ember/no-test-import-export': 'error',
'ghost/ember/no-test-module-for': 'error',
'ghost/ember/no-test-support-import': 'error',
'ghost/ember/no-test-this-render': 'error',
'ghost/ember/prefer-ember-test-helpers': 'error',
'ghost/ember/require-valid-css-selector-in-test-helpers': 'error'
};

const mochaRulesOff = Object.fromEntries(
Object.keys(ghostPlugin.rules || {})
.filter(rule => rule.startsWith('mocha/'))
.map(rule => [`ghost/${rule}`, 'off'])
);

export default [
{
ignores: [
'dist/**',
'tmp/**',
'public/**',
'config/**',
'node_modules/**'
]
},
{
files: ['**/*.js'],
...js.configs.recommended,
languageOptions: {
parser: babelParser,
ecmaVersion: 2022,
sourceType: 'module',
parserOptions: {
allowImportExportEverywhere: false,
ecmaFeatures: {
globalReturn: false,
legacyDecorators: true,
jsx: true
},
requireConfigFile: false,
babelOptions: {
plugins: [
'@babel/plugin-proposal-class-properties',
['@babel/plugin-proposal-decorators', {legacy: true}],
'babel-plugin-transform-react-jsx'
]
}
},
globals: {
...globals.browser,
...globals.node
}
},
plugins: {
ghost: ghostPlugin,
ember: emberPlugin,
react: reactPlugin,
'local-filenames': localFilenamesPlugin
},
rules: {
...js.configs.recommended.rules,
...ghostBaseRules,
...emberRules,
'local-filenames/match-regex': ['error', '^[a-z0-9.-]+$', false],
// Legacy ghost/admin overrides
'ghost/ember/no-controller-access-in-routes': 'off',
'ghost/ember/no-assignment-of-untracked-properties-used-in-tracking-contexts': 'off',
'ghost/ember/no-actions-hash': 'off',
'ghost/ember/no-classic-classes': 'off',
'ghost/ember/no-classic-components': 'off',
'ghost/ember/require-tagless-components': 'off',
'ghost/ember/no-component-lifecycle-hooks': 'off',
'ghost/ember/use-ember-get-and-set': 'off',
'ghost/ember/no-mixins': 'off',
'ghost/ember/no-new-mixins': 'off',
'react/jsx-uses-react': 'error',
'react/jsx-uses-vars': 'error'
}
},
// Tests: mocha + embertest envs (sinon + should are legacy ghost/test globals)
{
files: ['tests/**/*.js'],
languageOptions: {
globals: {
...globals.browser,
...globals.node,
...globals.mocha,
...globals.embertest,
sinon: 'readonly',
should: 'readonly'
}
},
rules: {
...mochaRulesOff,
'ghost/ember/no-invalid-debug-function-arguments': 'off',
'ghost/mocha/no-setup-in-describe': 'off'
}
}
];
6 changes: 0 additions & 6 deletions ghost/admin/mirage/.eslintrc.js
View file
Open in desktop

This file was deleted.

7 changes: 6 additions & 1 deletion ghost/admin/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,13 @@
"ember-test-selectors": "6.0.0",
"ember-tooltips": "3.6.0",
"ember-truth-helpers": "3.1.1",
"eslint": "catalog:",
"@eslint/js": "catalog:eslint9",
"eslint": "catalog:eslint9",
"eslint-plugin-babel": "5.3.1",
"eslint-plugin-ember": "12.7.5",
"eslint-plugin-ghost": "3.5.0",
"eslint-plugin-react": "7.37.5",
"globals": "17.6.0",
"flexsearch": "0.7.43",
"fs-extra": "catalog:",
"ghost": "workspace:*",
Expand Down
Loading
Loading