Skip to content

Co-locate gift-links response serializers in the service module#28809

Draft
rob-ghost wants to merge 1 commit into
chore/gift-links-colocate-db-concernsfrom
chore/gift-links-colocate-serializers
Draft

Co-locate gift-links response serializers in the service module#28809
rob-ghost wants to merge 1 commit into
chore/gift-links-colocate-db-concernsfrom
chore/gift-links-colocate-serializers

Conversation

@rob-ghost

@rob-ghost rob-ghost commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Problem

The gift-links response serialization lived in the API serializer layer, away from the rest of the module's concerns — its database mapping, queries, models, and service. The logic for one feature was split across two parts of the codebase.

Solution

Move the whole serialization — the response schemas, the transforms, and the endpoint-to-schema mapping — into the gift-links service module as a pure ES module, so it sits alongside the module's other concerns. The framework's output serializer registry points straight at it, so there is no separate adapter file. The module now owns all of its concerns in one place.

Stacked on #28783 — review this as the serializer move on top of that branch's data-layer split. Retargets to main once that merges.

@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 09e2662f-5ceb-4eae-a6ec-540d6aa331a5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/gift-links-colocate-serializers

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Jun 22, 2026

Copy link
Copy Markdown

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci


View your CI Pipeline Execution ↗ for commit e7fee58

Command Status Duration Result
nx run ghost:test:ci:integration ✅ Succeeded 2m 2s View ↗
nx run ghost:test:ci:integration:no-coverage ✅ Succeeded 2m 10s View ↗
nx run ghost:test:ci:e2e ✅ Succeeded 7m 21s View ↗
nx run ghost:test:ci:e2e:no-coverage ✅ Succeeded 6m 33s View ↗
nx build @tryghost/signup-form ✅ Succeeded 1s View ↗
nx build @tryghost/announcement-bar ✅ Succeeded <1s View ↗
nx build @tryghost/activitypub ✅ Succeeded 1s View ↗
nx build @tryghost/portal ✅ Succeeded 1s View ↗
Additional runs (10) ✅ Succeeded ... View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-06-22 23:17:56 UTC

no ref

The full response serialization (schemas, transforms and the endpoint-to-schema mapping) now lives in the gift-links service module as a pure ES module, alongside its database, queries, models and service. The API output serializer registry points straight at it, so there is no separate boundary file in the framework directory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant