Co-locate gift-links response serializers in the service module#28809
Co-locate gift-links response serializers in the service module#28809rob-ghost wants to merge 1 commit into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run ghost:test:ci:integration |
✅ Succeeded | 2m 2s | View ↗ |
nx run ghost:test:ci:integration:no-coverage |
✅ Succeeded | 2m 10s | View ↗ |
nx run ghost:test:ci:e2e |
✅ Succeeded | 7m 21s | View ↗ |
nx run ghost:test:ci:e2e:no-coverage |
✅ Succeeded | 6m 33s | View ↗ |
nx build @tryghost/signup-form |
✅ Succeeded | 1s | View ↗ |
nx build @tryghost/announcement-bar |
✅ Succeeded | <1s | View ↗ |
nx build @tryghost/activitypub |
✅ Succeeded | 1s | View ↗ |
nx build @tryghost/portal |
✅ Succeeded | 1s | View ↗ |
Additional runs (10) |
✅ Succeeded | ... | View ↗ |
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗
☁️ Nx Cloud last updated this comment at 2026-06-22 23:17:56 UTC
no ref The full response serialization (schemas, transforms and the endpoint-to-schema mapping) now lives in the gift-links service module as a pure ES module, alongside its database, queries, models and service. The API output serializer registry points straight at it, so there is no separate boundary file in the framework directory.
e7fee58 to
fed7436
Compare

Problem
The gift-links response serialization lived in the API serializer layer, away from the rest of the module's concerns — its database mapping, queries, models, and service. The logic for one feature was split across two parts of the codebase.
Solution
Move the whole serialization — the response schemas, the transforms, and the endpoint-to-schema mapping — into the gift-links service module as a pure ES module, so it sits alongside the module's other concerns. The framework's output serializer registry points straight at it, so there is no separate adapter file. The module now owns all of its concerns in one place.
Stacked on #28783 — review this as the serializer move on top of that branch's data-layer split. Retargets to
mainonce that merges.