Cleaned dead eslint-plugin-ember import from ghost/admin

[9larsons]

ghost/admin's eslint.config.mjs imported and registered eslint-plugin-ember as a bare ember plugin, but every ember rule used in the file is the ghost-namespaced variant (73 ghost/ember/* rules, 0 bare ember/*). Those resolve via eslint-plugin-ghost, which already lists eslint-plugin-ember as a direct dependency — so dropping the direct devDep + plugin registration changes nothing at lint time.

Verified: pnpm lint (eslint + ember-template-lint) passes.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 85bd47ba-47fc-42a7-8ed0-95d6ca72b840

📥 Commits

Reviewing files that changed from the base of the PR and between e222261 and 255b87e.

⛔ Files ignored due to path filters (1)

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (2)

• ghost/admin/eslint.config.mjs
• ghost/admin/package.json

💤 Files with no reviewable changes (2)

• ghost/admin/package.json
• ghost/admin/eslint.config.mjs

---

Walkthrough

The eslint-plugin-ember package is removed from the ghost/admin ESLint configuration. In eslint.config.mjs, the import statement for eslint-plugin-ember is deleted and the ember: emberPlugin entry is removed from the plugins map in the main JS files configuration, leaving ghost, react, and local-filenames plugins. Correspondingly, the eslint-plugin-ember devDependency (version 12.7.5) is removed from ghost/admin/package.json.

Possibly related PRs

• TryGhost/Ghost#28808: Directly related — that PR added eslint-plugin-ember to the ESLint 9 flat config in ghost/admin/eslint.config.mjs; this PR reverses that by removing it.

Suggested reviewers

• EvanHahn

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes removing the dead eslint-plugin-ember import and registration from ghost/admin.
Description check	✅ Passed	The description matches the change and explains why removing the direct dependency is safe.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch drop-dead-ember-plugin

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[nx-cloud]

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci

---

View your CI Pipeline Execution ↗ for commit 255b87e

Command	Status	Duration	Result
nx run @tryghost/admin-x-settings:test:acceptance	✅ Succeeded	10m 35s	View ↗
nx build @tryghost/comments-ui	✅ Succeeded	<1s	View ↗
nx build @tryghost/admin-toolbar	✅ Succeeded	<1s	View ↗
nx build @tryghost/sodo-search	✅ Succeeded	<1s	View ↗
nx build @tryghost/announcement-bar	✅ Succeeded	<1s	View ↗
nx build @tryghost/activitypub	✅ Succeeded	2s	View ↗
nx build @tryghost/portal	✅ Succeeded	<1s	View ↗
nx build @tryghost/signup-form	✅ Succeeded	<1s	View ↗
Additional runs (14)	✅ Succeeded	...	View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗

---

☁️ Nx Cloud last updated this comment at 2026-06-24 14:49:10 UTC

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.22%. Comparing base (9bb3471) to head (255b87e).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #28861      +/-   ##
==========================================
- Coverage   74.25%   74.22%   -0.03%     
==========================================
  Files        1563     1563              
  Lines      134925   134932       +7     
  Branches    16368    16363       -5     
==========================================
- Hits       100191   100157      -34     
- Misses      33752    33765      +13     
- Partials      982     1010      +28     

Flag	Coverage Δ
admin-tests	55.16% <ø> (ø)
e2e-tests	76.36% <ø> (-0.04%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.