Feat: sdk v11#136
Open
tuna1207 wants to merge 4 commits into
Open
Conversation
| "node:crypto": require.resolve("react-native-quick-crypto"), | ||
| "node:crypto": quickCryptoPath, | ||
| "node:stream": require.resolve("readable-stream"), | ||
| "node:buffer": require.resolve("buffer"), |
Member
There was a problem hiding this comment.
we should be able to remove some polyfills here
| type SdkSpecificInitParams = { | ||
| enableLogging?: boolean; | ||
| useCoreKitKey?: boolean; | ||
| useMpc?: boolean; |
| "@toruslabs/session-manager": "^5.6.0", | ||
| "@toruslabs/torus.js": "^17.2.3", | ||
| "@web3auth/auth": "^11.8.1", | ||
| "@web3auth/ethereum-provider": "^9.7.0", |
Member
There was a problem hiding this comment.
we can do more here. Let's do a better clean up at the end
Member
There was a problem hiding this comment.
don't action now. we will do in the last pr
| } else if (options.buildEnv === BUILD_ENV.STAGING) { | ||
| options.sdkUrl = "https://staging-auth.web3auth.io"; | ||
| options.dashboardUrl = "https://staging-account.web3auth.io/wallet/account"; | ||
| options.dashboardUrl = "https://staging-account.web3auth.io"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Jira Link:
Description
Aligns @web3auth/react-native-sdk with @web3auth/auth v11 (citadel session model), matching the web SDK. This is a major release (10.0.0) that upgrades core dependencies, migrates the main auth flow from legacy StorageManager to AuthSessionManager, and updates versioned auth/dashboard URLs.
Changes
Dependency upgrades
Citadel session manager (main auth flow)
URLs & versioning
Metro config
Version bump
Architecture
Web3Auth
├── sessionManager: AuthSessionManager (citadel) — main auth flow
├── sfaSessionManager?: StorageManager — SFA only
├── currentSessionId — connected state
└── createLoginSession() — legacy StorageManager for login payload staging
Breaking changes
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Note
High Risk
Changes core login, session restore, logout, and MFA flows and token storage—any mismatch with auth v11 redirects or Citadel will break existing integrations until apps migrate.
Overview
Upgrades the React Native SDK to @web3auth/auth v11 and shifts the standard login path from session-service–only storage to Citadel via
AuthSessionManager, with tokens persisted in secure storage through a newKeyStoreAdapter.Auth redirects now expect the full v11 token set (
sessionId,accessToken,refreshToken,idToken); login, MFA enablement, init rehydration, and logout usesetTokens/authorize()/logout()instead of writing a legacy KeyStoresessionId. SFA (idTokenflows) still usesStorageManageron the storage server, with a KeyStore flag to pick the right path on restore.Init adds defaulted
citadelServerUrl,storageServerUrl, andsessionSocketUrl, and production URLs are versioned (auth/dashboard major from@web3auth/auth, wallet/v5).getHashQueryParamsandconnected/currentSessionIdtracking were updated for this model.Metro
withWeb3Authgains resolver fixes for@noble/hashes/cryptoand deep@web3auth/no-modal/distimports;fetchProjectConfigsurfaces API error bodies more clearly.Reviewed by Cursor Bugbot for commit 081c4a6. Bugbot is set up for automated code reviews on this repo. Configure here.