Add pre and post service buffer time, so that availability gets generated with the required "gaps" depending on the selected service#1746
Draft
hidde-s wants to merge 14 commits into
Conversation
Added buffer properties and now takes them into account when calculating availability
Owner
|
Hello! Thanks for submitting this PR. I will take a closer look and merge acordingly.
|
|
Very excited for this PR |
ZzyzXVegas
reviewed
Nov 5, 2025
ZzyzXVegas
left a comment
ZzyzXVegas
left a comment
There was a problem hiding this comment.
Hello hidde-s,
I made the changes to the files outlined here (manually added the buffer_before and buffer_after columns to the services table), but changes to the services form do not write to the database.
I entered values manually in the database, but they are not seen from the services page.
Any suggestions?
Author
|
Weird, but now I am having the same issue when testing this pr. |
Author
|
@ZzyzXVegas I'm now no longer having this issue.
Would you mind following these steps (you don't have to use an empty database) and checking again? |
Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.1.2 to 3.1.5. - [Changelog](https://github.com/isaacs/minimatch/blob/main/changelog.md) - [Commits](isaacs/minimatch@v3.1.2...v3.1.5) --- updated-dependencies: - dependency-name: minimatch dependency-version: 3.1.5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…/npm_and_yarn/minimatch-3.1.5 Bump minimatch from 3.1.2 to 3.1.5
Bumps [immutable](https://github.com/immutable-js/immutable-js) from 4.3.5 to 4.3.8. - [Release notes](https://github.com/immutable-js/immutable-js/releases) - [Changelog](https://github.com/immutable-js/immutable-js/blob/main/CHANGELOG.md) - [Commits](immutable-js/immutable-js@v4.3.5...v4.3.8) --- updated-dependencies: - dependency-name: immutable dependency-version: 4.3.8 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…/npm_and_yarn/immutable-4.3.8 Bump immutable from 4.3.5 to 4.3.8
|
Is it possible to rebase/merge this PR with the develop branche? We like to test this PR on the latest version. |
Bumps [phpseclib/phpseclib](https://github.com/phpseclib/phpseclib) from 3.0.43 to 3.0.50. - [Release notes](https://github.com/phpseclib/phpseclib/releases) - [Changelog](https://github.com/phpseclib/phpseclib/blob/master/CHANGELOG.md) - [Commits](phpseclib/phpseclib@3.0.43...3.0.50) --- updated-dependencies: - dependency-name: phpseclib/phpseclib dependency-version: 3.0.50 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…/composer/phpseclib/phpseclib-3.0.50 Bump phpseclib/phpseclib from 3.0.43 to 3.0.50
Bumps [picomatch](https://github.com/micromatch/picomatch) from 2.3.1 to 2.3.2. - [Release notes](https://github.com/micromatch/picomatch/releases) - [Changelog](https://github.com/micromatch/picomatch/blob/master/CHANGELOG.md) - [Commits](micromatch/picomatch@2.3.1...2.3.2) --- updated-dependencies: - dependency-name: picomatch dependency-version: 2.3.2 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
…/npm_and_yarn/picomatch-2.3.2 Bump picomatch from 2.3.1 to 2.3.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello everyone,
This is the start of a pull request for #1224. I have had it implemented in my main install for a bit now and it's working great. The buffer time is adjustable for each service and is taken into account when customers make new appointments.
I have already made a database migration file (I am not sure how any of this migration stuff works, so please check my work).
What should still be done:
Any help would be appreciated.