feature: Embed Invite#1908
Open
BadPirate wants to merge 6 commits into
Open
Conversation
Feature ask, allow embedding of calendar on other websites through iframe. Changes to service edit page to show the HTML that would allow for embedding as well as a preview for each service, as well as tokens to allow cross site usage. Set EMBED_ALLOWED_ORIGINS ENV to allow for embedding into other sites.
Author
|
@alextselegidis -- So....... In the process of making this merge, I just noticed that your develop branch already has something almost identical to what I just built. I'm going to leave this here (as it's 11:30p in Netherlands) and de-conflict the efforts when I'm fresh. |
Author
|
Okay, since I'm tired, I had cursor take a look at the merge mess, and it's not as bad as I thought. Here's what the machines think: cursor_booking_widget_embedding_efforts.md From my diff:
|
Deleted the ALLOWALL helper from security_helper.php Removed all 10 per-controller calls apply_frame_embedding_headers() - If embedded updated changelog
Author
|
Okay, resolved merge issues, combined functionality, and verified on my test server https://dev.gaaf.kaperkun.de/embed-test/ |
Changing language in a cross-origin iframe stored the preference in session, but third-party cookies are blocked so the reload fell back to the original language query param. Navigate with an updated language param instead when the booking page is embedded. Co-authored-by: Cursor <cursoragent@cursor.com>
Traditional CAPTCHA stores its phrase in the session, but embed mode only upgraded CSRF cookies to SameSite=None while session cookies stayed Lax and were blocked in third-party iframes. Issue cross-site session cookies for public booking flow routes including captcha. Co-authored-by: Cursor <cursoragent@cursor.com> fixup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #543 - Providing the ability to embed calendar services directly into external websites
Testing
Additional testing post merge
On my own host, launched with the latest develop branch (including some of the initial embed changes like language embedding from @alextselegidis) and deployed:
https://dev.gaaf.kaperkun.de/embed-test/ -- This host is in the EMBED_ALLOWED_ORIGINS (works)
https://bad.dev.gaaf.kaperkun.de/embed-test/ -- This host is not in EMBED_ALLOWED_ORIGINS (fails)
Screenshots