fix(mcp): drop empty-string optional args before tools/call#33626
Open
Haohao-end wants to merge 1 commit into
Open
fix(mcp): drop empty-string optional args before tools/call#33626Haohao-end wants to merge 1 commit into
Haohao-end wants to merge 1 commit into
Conversation
OpenAI/GPT fills omitted optional string params with "", which MCP servers treat as explicit values (e.g. Slack search cursor/after/before returning no results). Add cleanToolArguments to strip empty strings for non-required properties before calling tools/call, matching the Anthropic path where unset optionals are omitted entirely. Closes anomalyco#33341
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #33341
Type of change
What does this PR do?
On the OpenAI/GPT path, omitted optional MCP string parameters are serialized as
"". MCP servers like Slack treat these as explicit values, so search tools (e.g.slack_search_channels) return no results. The Anthropic path omits unset optionals and works fine.This adds
cleanToolArguments()inpackages/opencode/src/mcp/catalog.tsthat drops empty-string values for non-required properties before thetools/callrequest, using the tool'sinputSchemato tell required from optional. Unknown keys and non-string falsy values are left untouched.How did you verify your code works?
bun test ./test/mcp/catalog.test.ts— 8 tests covering: dropping empty optionals, keeping required fields, keeping non-empty optionals, keeping falsy non-string values, leaving unknown keys, normalizing non-object args, and all-optional schemas. All 8 pass.Screenshots / recordings
N/A — not a UI change.
Checklist