fix(opencode): resolve MCP prompts with real arguments, not $N placeholders#33639
Open
Haohao-end wants to merge 1 commit into
Open
fix(opencode): resolve MCP prompts with real arguments, not $N placeholders#33639Haohao-end wants to merge 1 commit into
Haohao-end wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #33564
Type of change
What does this PR do?
MCP prompt commands sent literal
$1/$2strings as argument values toprompts/getwhen registering commands. Servers that validate argument types (e.g.precision: int) rejected them, loggingfailed to getPromptat startup and leaving the command with an empty template.Since
listPromptsargument metadata has no type info, a type-correct placeholder can't be synthesized. Instead, resolve MCP prompt templates at invocation: store prompt metadata inCommand.stateand addCommand.template(name, args), which callsgetPromptwith the user's real positional arguments (servers coerce numeric strings). Non-MCP commands are unchanged.How did you verify your code works?
noUncheckedIndexedAccessis off, soargs[i]isstring)precision: int) no longer logs$2/$1conversion errors at startup; invoking it with real args renders the prompt server-sideChecklist