fix: implement v2 session wait#33643
Open
Xiaxinyuuu wants to merge 1 commit into
Open
Conversation
Co-authored-by: Starchild <noreply@iamstarchild.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fixes #33605
Type of change
What does this PR do?
POST /api/session/:sessionID/waitis documented as waiting for a session agent loop to become idle, butSessionV2.wait()currently returnsOperationUnavailableError, so the endpoint always responds with503for existing sessions.This PR wires
SessionV2.wait()to the local session execution coordinator:wait()does not start new work by itselfIt also updates the HTTP API contract so the wait endpoint no longer documents
ServiceUnavailableError.How did you verify your code works?
204from/api/session/:sessionID/wait/waitno longer documents a503unfinished-operation responsegit diff --checkI could not run the full test suite in this workspace because dependencies were not installed and Bun is not available here.
Screenshots / recordings
Not a UI change.
Checklist