fix(session): handle type validation errors gracefully#33645
Open
Haohao-end wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #31324
Type of change
What does this PR do?
When the AI SDK receives a non-standard response chunk (e.g. from MCP-related tool calls), it emits a
TypeValidationError(name: "AI_TypeValidationError"). The previous code calledEffect.fail(event.error)which crashed the stream, leaving the assistant message in a broken state.Two changes:
ai-sdk.ts:TypeValidationErrorerrors are now converted toLLMEvent.providerErrorevents instead of failing the stream. Other error types (e.g.APICallError) still useEffect.failso retry/classification logic is unaffected.processor.ts: Theprovider-errorhandler now checks theretryableflag. Retryable errors still throw to trigger the retry policy. Non-retryable errors callhalt()which flushes partial fragments, sets the error on the assistant message, publishes the error event, and sets session status to idle — the same graceful shutdown path used for other terminal errors.How did you verify your code works?
bun typecheck— passesbun test test/session/— 362 pass, 0 failprocessor-effect.test.tstests pass (including retry, context-overflow, and error-classification tests)llm.test.tstests passScreenshots / recordings
N/A
Checklist