fix(plugin): skip mismatched detected plugins#33661
Open
lin-hongkuan wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #31610
Type of change
What does this PR do?
readV1Plugin(..., "detect")currently skips non-plugin modules, but it still throws when a plugin has only the opposite entrypoint. That makes a TUI-only plugin noisy when the server plugin loader probes it withkind = "server".This PR keeps strict mode unchanged, and keeps invalid present entrypoints as errors, but in detect mode returns
undefinedwhen the requested entrypoint is absent. That lets the caller skip mismatched plugins instead of logging a misleading load error.How did you verify your code works?
bun test test/plugin/shared.test.tsfrompackages/opencodebun run typecheckfrompackages/opencodegit diff --checkfrom the repo rootScreenshots / recordings
Not applicable; this is plugin loader behavior.
Checklist
If you do not follow this template your PR will be automatically rejected.