fix(ui): guard session review diffs#33664
Open
lin-hongkuan wants to merge 1 commit into
Open
Conversation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #19268
Type of change
What does this PR do?
SessionReviewalready had a local normalizer for diff-like payloads, but one path still calledprops.diffs.map(...)directly. If a stale or malformed session payload suppliedsummary.diffsas an object, null, or another non-array value, the review UI could crash before the normalizer helped.This PR moves the review diff normalizer into a small pure module, uses it for both the diff map and file list, and widens the component prop to accept unknown runtime payloads defensively.
How did you verify your code works?
bun test src/components/session-review.test.tsfrompackages/uibun run typecheckfrompackages/uibun run typecheckfrompackages/appgit diff --checkfrom the repo rootScreenshots / recordings
Not included; this is a defensive crash fix for malformed diff data.
Checklist
If you do not follow this template your PR will be automatically rejected.