fix(limit-conn): isolate counter per workflow action via _vid key#13591
Open
shreemaan-abhishek wants to merge 1 commit into
Open
fix(limit-conn): isolate counter per workflow action via _vid key#13591shreemaan-abhishek wants to merge 1 commit into
shreemaan-abhishek wants to merge 1 commit into
Conversation
When multiple limit-conn actions are configured in a single workflow rule, the workflow plugin sets a per-action _vid on each conf but limit-conn never folded it into the limit key, so all actions shared one connection counter instead of being limited independently. Fold _vid into the key, matching what limit-count already does.
dosubot
Bot
added
size:L
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When two or more
limit-connactions are configured inside a singleworkflowrule, theworkflowplugin assigns each action a distinct_vidon its conf, butlimit-connnever folds that_vidinto the limit key. As a result every action builds the same shared counter key and the actions throttle one combined connection counter instead of being limited independently.limit-countalready folds_vidinto its key for exactly this reason, so this is an inconsistency specific tolimit-conn. This PR bringslimit-connto parity by appending_vidto the key when present, and adds aworkflow3.ttest with two independentlimit-connactions.Which issue(s) this PR fixes:
N/A
Checklist