introduce decode benchmarks#10202
Merged
Merged
Conversation
github-actions
Bot
added
arrow
Contributor
Author
|
@alamb / @gabotechs smaller PR |
alamb
approved these changes
Jun 23, 2026
| let batch = build_batch(name, rows, cols, build); | ||
| let frames: Vec<FlightData> = rt | ||
| .block_on( | ||
| FlightDataEncoderBuilder::new() |
Contributor
There was a problem hiding this comment.
I was wondering if it also made sense to benchmark decoding more than one batch (for example, a stream with replacement dictionary) but I think for now this is good
Contributor
Author
There was a problem hiding this comment.
I made a follow up PR for that here #10207 🚀
alamb
pushed a commit
that referenced
this pull request
Jun 24, 2026
# Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. --> Follow up of #10202 , see [comment](#10202 (comment)) works towards #10125 # Rationale for this change this provides more visibility to performances changes that occurs on the decode path. Multi batch decoding is more representative of real world work loads. <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> # What changes are included in this PR? Added multi-batch decode benchmarks covering both plain and dictionary types, including the replacement-dictionary path, <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> # Are these changes tested? n/a <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? If this PR claims a performance improvement, please include evidence such as benchmark results. --> # Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. If there are any breaking changes to public APIs, please call them out. --> no
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
there were no benchmarks for the decode path
What changes are included in this PR?
single benchmark that measures the time it takes to decode a stream of
flight_dataAre these changes tested?
n/a
Are there any user-facing changes?
no