-
Notifications
You must be signed in to change notification settings - Fork 4.2k
GH-49677 [Python][C++][Compute] Add search sorted compute kernel #49679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Alex-PLACET
wants to merge
36
commits into
apache:main
Choose a base branch
from
Alex-PLACET:add_search_sorted_compute_kernel
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,385
−3
Open
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
e5a83c9
Implement benchmarks and tests for SearchSorted functionality
Alex-PLACET e4b2e36
Refactor vector_search_sorted kernel to use ArrayData and add benchma…
Alex-PLACET 17b666f
Enhance documentation for search_sorted kernel with detailed implemen…
Alex-PLACET 881f5b8
Refactor vector_search_sorted kernel to improve null handling and uti…
Alex-PLACET 56f6918
Refactor search_sorted kernel: improve error messages and add compreh…
Alex-PLACET b3c4e50
Formatting
Alex-PLACET 20372d1
Refactor vector_search_sorted kernel: enhance readability and add noe…
Alex-PLACET 1c0462c
Refactor search_sorted documentation: adjust indentation for clarity
Alex-PLACET bbac1e5
Implement chunked array support in search_sorted: enhance validation …
Alex-PLACET a56bcfd
Refactor CheckSimpleScalarSearchSorted: support multiple needles and …
Alex-PLACET 8ebd6ec
Add tests for chunked run-end encoded values and needles in SearchSorted
Alex-PLACET 660182e
formatting
Alex-PLACET 277c76a
Refactor search_sorted: extract null counting logic into reusable fun…
Alex-PLACET 925025c
Formatting
Alex-PLACET 92ea85d
Fix benchmark
Alex-PLACET dfaa478
Refactor SearchSorted tests: consolidate assertions into reusable Che…
Alex-PLACET 645fd23
Refactor SearchSorted tests: rename and enhance scalar search functio…
Alex-PLACET 57d34c5
Update SearchSorted tests: modify input values and needles for consis…
Alex-PLACET aa95c22
Add tests for sliced ChunkedRunEndEncodedValues and handle all-null c…
Alex-PLACET 129a743
Add FindNonNullValuesRange method annotation and new test for Chunked…
Alex-PLACET 94f7577
Remove redundant check for RUN_END_ENCODED type in ReadChunkValue method
Alex-PLACET 866b93c
Add chunked array support for search sorted operations and enhance te…
Alex-PLACET a5b2226
Formatting
Alex-PLACET d7433cb
Add support for run-end encoded needles in search sorted operations
Alex-PLACET 5a182e0
Refactor search sorted output handling to use InsertionIndexBuilder f…
Alex-PLACET b28285d
Enhance search sorted functionality by adding tests for sliced run-en…
Alex-PLACET a9da407
Fix
Alex-PLACET c524341
Refactor search sorted to dispatch on physical types
Alex-PLACET 34eddc7
fix
Alex-PLACET 60e7037
Reject interspersed nulls in search_sorted values
Alex-PLACET 2bb3e7d
fix casting
Alex-PLACET e702161
formatting
Alex-PLACET 161b0c0
Add documentation and address comments
Alex-PLACET 3a40b63
wip
Alex-PLACET 9943c43
fix conversion
Alex-PLACET 8c9ec3f
formatting
Alex-PLACET File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why this change was necessary?