GH-50267: [C++][Parquet] Upgrade thrift compiler from 0.21.0 to 0.23.0#50268
Open
HuaHuaY wants to merge 2 commits into
Open
GH-50267: [C++][Parquet] Upgrade thrift compiler from 0.21.0 to 0.23.0#50268HuaHuaY wants to merge 2 commits into
HuaHuaY wants to merge 2 commits into
Conversation
|
|
github-actions
Bot
added
Component: Parquet
Component: C++
awaiting review
Contributor
Author
|
This PR is based on #50265 to avoid git conflict. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Thrift 0.22.0 removed virtual in generated code when templates feature is enabled. So it will not generate unnecessary vtables for the class.
What changes are included in this PR?
Just update generated code.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.