HBASE-30272 Compatiblity checker can not compile rel/2.0.0 when relea…#8451
Open
Apache9 wants to merge 3 commits into
Open
HBASE-30272 Compatiblity checker can not compile rel/2.0.0 when relea…#8451Apache9 wants to merge 3 commits into
Apache9 wants to merge 3 commits into
Conversation
…sing 3.0.0-beta-2
There was a problem hiding this comment.
Pull request overview
This PR updates HBase’s release-time API compatibility checking (the dev-support/checkcompatibility.py build step invoked from the create-release scripts) to build checked-out source trees with an appropriate JDK (Java 8 vs Java 17), based on the checked-out tree’s Maven version.
Changes:
- Pass
--java8_home/--java17_homefrom the release scripts intocheckcompatibility.py. - Add logic in
checkcompatibility.pyto parsepom.xmland select whichJAVA_HOMEto use duringmvn package. - Add CLI flags to configure both JDK homes for mixed-version comparisons (e.g., rel/2.0.0 vs 3.x).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| dev-support/create-release/release-util.sh | Passes Java 8/17 home paths into the compatibility checker invocation. |
| dev-support/checkcompatibility.py | Adds POM parsing and per-tree JAVA_HOME selection to build older/newer branches with different JDKs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
liuxiaocs7
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…sing 3.0.0-beta-2