Add support for reading Theta sketch Puffin file#3574
Draft
ebyhr wants to merge 1 commit into
Draft
Conversation
ebyhr
force-pushed
the
ebi/theta-sketches
branch
from
d393e58 to
58333f2
Compare
ebyhr
force-pushed
the
ebi/theta-sketches
branch
from
58333f2 to
9e86827
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
apache-datasketches-theta-v1was already listed as a valid blob type in PuffinBlobMetadata and BlobMetadata, but pyiceberg had no way to read the actual sketch data. This implements deserialization so callers can access NDV estimates stored in statistics Puffin files written by engines like Spark.Are these changes tested?
Yes.
Are there any user-facing changes?
Yes. New
pyiceberg/table/theta_sketch.pywith ThetaSketch class andtheta_sketches_from_puffin_filefunction. New optional dependencydatasketchesunder the datasketches extra.