ORC-2190: [C++] Reject compressed chunk length exceeding block size in C++ reader#2671
Closed
dongjoon-hyun wants to merge 1 commit into
Closed
ORC-2190: [C++] Reject compressed chunk length exceeding block size in C++ reader#2671dongjoon-hyun wants to merge 1 commit into
dongjoon-hyun wants to merge 1 commit into
Conversation
dongjoon-hyun
added a commit
that referenced
this pull request
Jul 7, 2026
…n C++ reader ### What changes were proposed in this pull request? This PR makes the ORC C++ reader reject a compressed chunk whose length exceeds the configured compression block size, matching the Java reader. https://github.com/apache/orc/blob/5d3cf1318b58416719e89169ae9d56f758311f7e/java/core/src/java/org/apache/orc/impl/InStream.java#L504-L507 ### Why are the changes needed? The Java reader already performs this check in `InStream.CompressedStream.readHeader`, but the C++ reader was missing it. This is a defense-in-depth hardening (not a CVE): the chunk length is already bounded to ~8MB by the 3-byte header, but the spec-mandated first check was absent on the C++ side. Well-formed files are unaffected. ### How was this patch tested? Pass the CIs with the newly added test case. ### Was this patch authored or co-authored using generative AI tooling? Generated-by: Claude Fable 5 Closes #2671 from dongjoon-hyun/ORC-2190. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit 6015de5) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR makes the ORC C++ reader reject a compressed chunk whose length exceeds the configured
compression block size, matching the Java reader.
orc/java/core/src/java/org/apache/orc/impl/InStream.java
Lines 504 to 507 in 5d3cf13
Why are the changes needed?
The Java reader already performs this check in
InStream.CompressedStream.readHeader, but the C++reader was missing it. This is a defense-in-depth hardening (not a CVE): the chunk length is already
bounded to ~8MB by the 3-byte header, but the spec-mandated first check was absent on the C++ side.
Well-formed files are unaffected.
How was this patch tested?
Pass the CIs with the newly added test case.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude Fable 5