-
Notifications
You must be signed in to change notification settings - Fork 615
HDDS-15456. Add SCM DB lookup and identify orphan(wrt SCM) and deleted-but-present containers #10547
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sreejasahithi
wants to merge
3
commits into
apache:master
Choose a base branch
from
sreejasahithi:HDDS-15456
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
HDDS-15456. Add SCM DB lookup and identify orphan(wrt SCM) and deleted-but-present containers #10547
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
122 changes: 122 additions & 0 deletions
122
.../org/apache/hadoop/ozone/debug/datanode/container/analyze/ScmContainerMetadataReader.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,122 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.hadoop.ozone.debug.datanode.container.analyze; | ||
|
|
||
| import static org.apache.hadoop.hdds.scm.metadata.SCMDBDefinition.CONTAINERS; | ||
|
|
||
| import java.io.File; | ||
| import java.io.IOException; | ||
| import java.util.Objects; | ||
| import java.util.Optional; | ||
| import org.apache.hadoop.hdds.conf.ConfigurationSource; | ||
| import org.apache.hadoop.hdds.scm.container.ContainerID; | ||
| import org.apache.hadoop.hdds.scm.container.ContainerInfo; | ||
| import org.apache.hadoop.hdds.scm.metadata.SCMDBDefinition; | ||
| import org.apache.hadoop.hdds.utils.db.CodecException; | ||
| import org.apache.hadoop.hdds.utils.db.DBStore; | ||
| import org.apache.hadoop.hdds.utils.db.DBStoreBuilder; | ||
| import org.apache.hadoop.hdds.utils.db.RocksDatabaseException; | ||
| import org.apache.hadoop.hdds.utils.db.Table; | ||
| import org.apache.hadoop.hdds.utils.db.cache.TableCache.CacheType; | ||
| import org.apache.hadoop.ozone.OzoneConsts; | ||
|
|
||
| /** | ||
| * Read-only lookup of container metadata from {@code scm.db}. | ||
| */ | ||
| public final class ScmContainerMetadataReader implements AutoCloseable { | ||
|
|
||
| private final DBStore dbStore; | ||
| private final Table<ContainerID, ContainerInfo> containerTable; | ||
|
|
||
| public ScmContainerMetadataReader(ConfigurationSource conf, File scmDbPath) | ||
| throws IOException { | ||
| File scmDbDir = resolveScmDbDirectory(scmDbPath); | ||
| File parentDir = scmDbDir.getParentFile(); | ||
| if (parentDir == null) { | ||
| throw new IOException("SCM database directory has no parent path: " + scmDbDir); | ||
| } | ||
| try { | ||
| this.dbStore = DBStoreBuilder.newBuilder(conf, SCMDBDefinition.get(), scmDbDir.getName(), | ||
| parentDir.toPath()) | ||
| .setOpenReadOnly(true) | ||
| .build(); | ||
| } catch (RocksDatabaseException e) { | ||
| throw new IOException("Failed to open SCM database at " + scmDbDir, e); | ||
| } | ||
| try { | ||
| this.containerTable = CONTAINERS.getTable(dbStore, CacheType.NO_CACHE); | ||
| } catch (RocksDatabaseException | CodecException e) { | ||
| dbStore.close(); | ||
| throw new IOException("Failed to open scm.db containers column family at " + scmDbDir, e); | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Classify a container ID against scm.db {@code containers}. | ||
| * | ||
| * @return {@link Optional#empty()} when the container is present in SCM with a | ||
| * non-DELETED lifecycle state | ||
| */ | ||
| public Optional<ScmContainerClassification> classify(long containerId) throws IOException { | ||
| try { | ||
| ContainerInfo info = containerTable.get(ContainerID.valueOf(containerId)); | ||
| if (info == null) { | ||
| return Optional.of(ScmContainerClassification.NOT_IN_SCM); | ||
| } | ||
| if (info.isDeleted()) { | ||
| return Optional.of(ScmContainerClassification.DELETED); | ||
| } | ||
| return Optional.empty(); | ||
| } catch (RocksDatabaseException | CodecException e) { | ||
| throw new IOException("Failed to read container " + containerId + " from scm.db", e); | ||
| } | ||
| } | ||
|
|
||
| static File resolveScmDbDirectory(File path) throws IOException { | ||
| Objects.requireNonNull(path, "scmDbPath"); | ||
| File absolutePath = path.getAbsoluteFile(); | ||
| File scmDbDir = absolutePath; | ||
| if (!OzoneConsts.SCM_DB_NAME.equals(absolutePath.getName())) { | ||
| File child = new File(absolutePath, OzoneConsts.SCM_DB_NAME); | ||
| if (child.isDirectory()) { | ||
| scmDbDir = child; | ||
| } | ||
| } | ||
| if (!scmDbDir.isDirectory()) { | ||
| throw new IOException("SCM database directory not found: " + path); | ||
| } | ||
| return scmDbDir; | ||
| } | ||
|
|
||
| @Override | ||
| public void close() { | ||
| if (dbStore != null) { | ||
| dbStore.close(); | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * SCM-side classification for an on-disk container directory. | ||
| */ | ||
| enum ScmContainerClassification { | ||
| /** No record for this container ID in scm.db {@code containers}. */ | ||
| NOT_IN_SCM, | ||
| /** Record exists and {@link ContainerInfo} state is DELETED. */ | ||
| DELETED | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if someone points to online live DB, it will fail, if another process holds the write lock.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. it is better if --scm-db point at an offline copy of scm.db, opening read-only does not avoid RocksDB lock contention if SCM is still running. Same I think can also be seen in ozone debug ldb scan right.