Skip to content

HDDS-15624. Return resolved bucket properties on getters for linked buckets#10553

Draft
SaketaChalamchala wants to merge 1 commit into
apache:masterfrom
SaketaChalamchala:HDDS-15624
Draft

HDDS-15624. Return resolved bucket properties on getters for linked buckets#10553
SaketaChalamchala wants to merge 1 commit into
apache:masterfrom
SaketaChalamchala:HDDS-15624

Conversation

@SaketaChalamchala

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Link buckets created with ozone sh bucket link store symlink metadata (sourceVolume, sourceBucket) plus placeholder operational fields (layout, replication, quotas, etc.). Operational getters on the client such as getBucketLayout() and getReplicationConfig() were returning those stored defaults instead of the source bucket’s values.

This change resolves source properties lazily — only when an operational getter is first called — so getBucket() / listBuckets() stay cheap and do not trigger extra RPCs per link bucket.

On the server, OzoneManager.getBucketInfo() does not change it still returns the raw OM DB row for link buckets. Internal OM operations that need source properties continue to use OzoneManagerUtils.getResolvedBucketInfo().

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-15624

How was this patch tested?

Unit Tests.

@errose28

Copy link
Copy Markdown
Contributor

@SaketaChalamchala it looks like this moving bucket resolution to the client side which is not correct. The server should resolve the bucket links and the links should be transparent to the client. If there are areas where the server has missed resolving the links they should be fixed there with no client side code changes.

cc @sumitagrawl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants