HDDS-15624. Return resolved bucket properties on getters for linked buckets#10553
Draft
SaketaChalamchala wants to merge 1 commit into
Draft
HDDS-15624. Return resolved bucket properties on getters for linked buckets#10553SaketaChalamchala wants to merge 1 commit into
SaketaChalamchala wants to merge 1 commit into
Conversation
Contributor
|
@SaketaChalamchala it looks like this moving bucket resolution to the client side which is not correct. The server should resolve the bucket links and the links should be transparent to the client. If there are areas where the server has missed resolving the links they should be fixed there with no client side code changes. cc @sumitagrawl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Link buckets created with
ozone sh bucket linkstore symlink metadata (sourceVolume, sourceBucket) plus placeholder operational fields (layout, replication, quotas, etc.). Operational getters on the client such asgetBucketLayout()andgetReplicationConfig()were returning those stored defaults instead of the source bucket’s values.This change resolves source properties lazily — only when an operational getter is first called — so
getBucket()/listBuckets()stay cheap and do not trigger extra RPCs per link bucket.On the server, OzoneManager.getBucketInfo() does not change it still returns the raw OM DB row for link buckets. Internal OM operations that need source properties continue to use
OzoneManagerUtils.getResolvedBucketInfo().What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15624
How was this patch tested?
Unit Tests.