HDDS-15602. Read pipeline ID does not need to use secure random#10571
Open
ivandika3 wants to merge 6 commits into
Open
HDDS-15602. Read pipeline ID does not need to use secure random#10571ivandika3 wants to merge 6 commits into
ivandika3 wants to merge 6 commits into
Conversation
ivandika3
changed the title
adoroszlai
reviewed
Jun 22, 2026
adoroszlai
left a comment
adoroszlai
left a comment
Contributor
There was a problem hiding this comment.
Thanks @ivandika3 for the patch. Functionality looks good. I'd like to suggest some changes to reduce duplication.
Contributor
Author
|
Thanks @adoroszlai for the suggestion. Applied. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
We found that the CPU time of createPipelineForRead during high read traffic is mostly spent waiting on the SecureRandom monitor lock during the UUID random generation. SecureRandom is static and therefore lock should be static which also contends with all other UUID generation and can affect performance (as per Amdahl's law). I don't think it is required to use SecureRandom for read pipeline ID since the read pipeline ID is not sensitive (AFAIK it's throwaway ID) and predicting the next read pipeline ID should not have any security implication
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15602
How was this patch tested?
CI