HDDS-15639. Adjust Upgrade status command to call OM intead of SCM#10579
Open
sodonnel wants to merge 6 commits into
Open
HDDS-15639. Adjust Upgrade status command to call OM intead of SCM#10579sodonnel wants to merge 6 commits into
sodonnel wants to merge 6 commits into
Conversation
github-actions
Bot
added
the
zdu
dombizita
reviewed
Jun 25, 2026
|
|
||
| String errOutput = errContent.toString(DEFAULT_ENCODING); | ||
| assertTrue(errOutput.contains("OM does not support ZDU")); | ||
| verify(omClient, never()).finalizeUpgrade(); |
Contributor
There was a problem hiding this comment.
Shouldn't this check queryUpgradeStatus()?
Suggested change
| verify(omClient, never()).finalizeUpgrade(); | |
| verify(omClient, never()).queryUpgradeStatus(); |
| out().println("Upgrade status:"); | ||
| out().println(" OM Finalized: " + status.getOmFinalized()); | ||
| out().println(" SCM Finalized: " + status.getHddsStatus().getScmFinalized()); | ||
| out().println(" Datanodes finalized: " + status.getHddsStatus().getNumDatanodesFinalized()); |
Contributor
There was a problem hiding this comment.
Maybe it's worth to phrase it differently, as the first two line are true/false and this is the number of finalized datanodes, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Change the
ozone admin upgrade statuscommand to call OM and return a combined status of OM and HDDS finalization details.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15639
How was this patch tested?
New unit tests