feat(core): update request retry statistics in real-time#3773
Open
harryautomazione wants to merge 1 commit into
Open
feat(core): update request retry statistics in real-time#3773harryautomazione wants to merge 1 commit into
harryautomazione wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves the issue where the
requestsRetriescounter and therequestRetryHistogramwere only updated once a request was fully handled (either succeeded or failed permanently).Updating these statistics only at the very end of a job lifecycle created a false impression of no errors during long-running crawls, and led to incomplete statistics if the crawler crashed or was migrated early.
Changes
registerRetry(retryCount: number)in theStatisticsclass to dynamically increment the globalrequestsRetriesand updaterequestRetryHistogramin real-time as soon as a retry is triggered.registerRetryand_saveRetryCountForJobto preventNaNor negative values from corrupting the statistics.0) inside the histogram to avoid sparse arrays which serialize tonullin JSON._saveRetryCountForJobto only record job completions at index0if no retries occurred, preventing duplicate counters.this.stats.registerRetry(request.retryCount)within the_requestFunctionErrorHandlerright after updating the request's retry count.statistics.test.tsto cover real-time tracking, negative/NaN input protection, and JSON serialization integrity.Fixes #2732