Rename Range Partitioned to consisent name#13386
Conversation
9deabb2 to
bbade3a
Compare
Result of foundationdb-pr-clang-ide on Linux RHEL 9
|
Result of foundationdb-pr-clang-ide on Linux RHEL 9
|
Result of foundationdb-pr-clang-arm on Linux RHEL 9
|
Result of foundationdb-pr-macos-m1 on macOS 14.x
|
Result of foundationdb-pr-clang-arm on Linux RHEL 9
|
Result of foundationdb-pr-cluster-tests on Linux RHEL 9
|
Result of foundationdb-pr on Linux RHEL 9
|
Result of foundationdb-pr-clang on Linux RHEL 9
|
Result of foundationdb-pr-clang on Linux RHEL 9
|
Result of foundationdb-pr on Linux RHEL 9
|
Result of foundationdb-pr-cluster-tests on Linux RHEL 9
|
Result of foundationdb-pr-macos-m1 on macOS 14.x
|
Result of foundationdb-pr-macos on macOS 14.x
|
Result of foundationdb-pr-macos on macOS 14.x
|
saintstack
left a comment
There was a problem hiding this comment.
This PR is for 8.0 only? range_backup_worker_enabled / range_backup_workers currently appear in DatabaseConfiguration JSON serialization/parsing, the cluster config schema, documented status JSON, and even the persisted config key namespace. Do we need to keep supporting old names as aliases (at least for reads / config parsing / downgrade compatibility)? Thanks.
Yes, this PR is only for 8.0 and range_backup_worker_enabled / range_backup_workers were introduced in 8.0 as well and is specific to RangePartitioned (Backup V3). Do we need to support old names in that case? |
You don't have to given its major version change but would be friendly if just accpeted old names for the new if public-facing knobs, etc. Might be of help listing out all the user-facing name changes so easy to add to a release note when comes time? |
bbade3a to
cc3f60f
Compare
Result of foundationdb-pr-macos-m1 on macOS 14.x
|
Result of foundationdb-pr-macos on macOS 14.x
|
Result of foundationdb-pr-clang-ide on Linux RHEL 9
|
Result of foundationdb-pr-clang-arm on Linux RHEL 9
|
Result of foundationdb-pr on Linux RHEL 9
|
Result of foundationdb-pr-cluster-tests on Linux RHEL 9
|
Result of foundationdb-pr-clang on Linux RHEL 9
|
cc3f60f to
183f217
Compare
Result of foundationdb-pr-clang-ide on Linux RHEL 9
|
Result of foundationdb-pr-macos-m1 on macOS 14.x
|
Result of foundationdb-pr-macos on macOS 14.x
|
Result of foundationdb-pr-clang-arm on Linux RHEL 9
|
Result of foundationdb-pr on Linux RHEL 9
|
Result of foundationdb-pr-cluster-tests on Linux RHEL 9
|
Result of foundationdb-pr-clang on Linux RHEL 9
|
Rename Backup V3 identifiers and trace events for consistency.
RangePartitionedBackup(e.g.RangePartitionedBackupData,enableRangePartitionedBackupWorker,rangePartitionedBackupWorkerEnabledKey).RangePartitionedBWprefix (e.g.RangePartitionedBWStart,RangePartitionedBWRecruitment).This affects camelCase, PascalCase, snake_case, and UPPER_SNAKE forms (e.g. config keys like
range_partitioned_backup_worker_enabledand knobs likeRANGE_PARTITIONED_BACKUP_VDIR_INTERVAL).No behavior change.
100k simulation completed:
20260623-175449-ak_bk_v3_rename-eb9b6189d97a14c4 compressed=True data_size=37257831 duration=2508760 ended=100000 fail_fast=10 max_runs=100000 pass=100000 priority=100 remaining=0 runtime=0:46:55 sanity=False started=100000 stopped=20260623-184144 submitted=20260623-175449 timeout=5400 username=ak_bk_v3_rename