Skip to content

Initialize endpoints in DD team collection tests #13405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tclinkenbeard-oai wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −0
Open

Initialize endpoints in DD team collection tests #13405

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions fdbserver/datadistributor/DDTeamCollection.actor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6244,6 +6244,13 @@ Future<Void> DDTeamCollection::printSnapshotTeamsInfo(Reference<DDTeamCollection

class DDTeamCollectionUnitTest {
public:
static void setTestEndpoint(StorageServerInterface& interface, int id) {
// These unit tests do not run storage server actors, but team tracking still logs each
// interface's address. Give every fixture interface a synthetic, unregistered endpoint.
interface.getValue =
PublicRequestStream<GetValueRequest>(Endpoint({ NetworkAddress(IPAddress(0x01010101), id) }, UID(id, 1)));
}

static std::unique_ptr<DDTeamCollection> testTeamCollection(
int teamSize,
Reference<IReplicationPolicy> policy,
Expand Down Expand Up @@ -6281,6 +6288,7 @@ class DDTeamCollectionUnitTest {
UID uid(id, 0);
StorageServerInterface interface;
interface.uniqueID = uid;
setTestEndpoint(interface, id);
interface.locality.set("machineid"_sr, Standalone<StringRef>(std::to_string(id)));
interface.locality.set("zoneid"_sr, Standalone<StringRef>(std::to_string(id % 5)));
interface.locality.set("data_hall"_sr, Standalone<StringRef>(std::to_string(id % 3)));
Expand Down Expand Up @@ -6336,6 +6344,7 @@ class DDTeamCollectionUnitTest {
UID uid(id, 0);
StorageServerInterface interface;
interface.uniqueID = uid;
setTestEndpoint(interface, id);
int process_id = id;
int dc_id = process_id / 1000;
int data_hall_id = process_id / 100;
Expand Down
Loading