Remove dead cold_cache_server error code left behind by #12486#13406
Open
virajchogle wants to merge 1 commit into
Open
Remove dead cold_cache_server error code left behind by #12486#13406virajchogle wants to merge 1 commit into
virajchogle wants to merge 1 commit into
Conversation
Ronitsabhaya75
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
cold_cache_server(error code 1003) was tied to the Storage Cache Server feature deleted in #12486. The error is no longer thrown anywhere in the codebase, and no code matches on it. It only exists as a sentinel in the source header and the auto-generated Go binding.Solution
Replace the entry in
flow/include/flow/error_definitions.hwith a// 1003 removedplaceholder so the number slot stays reserved, then regeneratebindings/go/src/fdb/error_codes_generated.go. Same pattern ase50558fd7("Remove dead quota throttling error").Testing done
cold_cache_server,error_code_cold_cache_server, orErrColdCacheServeranywhere in the tree (other than the two lines being removed).go run ./bindings/go/src/internal/gen_errors/main.go.