-
Notifications
You must be signed in to change notification settings - Fork 243
feat: add Premium Geo DB addon to project settings #2981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lohanidamodar
wants to merge
27
commits into
main
Choose a base branch
from
feat/project-premium-geo-db-addon
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
470b047
feat: add Premium Geo DB addon to project settings
lohanidamodar 5954b75
feat(settings): show price in premium geo DB enable dialog
lohanidamodar 7e73d36
update sdk
lohanidamodar 0e53210
feat(billing): render project addons in breakdown + use server addon …
lohanidamodar 66e615e
Merge remote-tracking branch 'origin/main' into feat/project-premium-…
lohanidamodar afb13fc
Merge remote-tracking branch 'origin/main' into feat/project-premium-…
lohanidamodar 13b0478
chore: bump @appwrite.io/console SDK to 95547fc
lohanidamodar 0cba797
Merge remote-tracking branch 'origin/main' into feat/project-premium-…
lohanidamodar 6fc000f
Merge remote-tracking branch 'origin/main' into feat/project-premium-…
lohanidamodar 304142c
chore: keep @appwrite.io/console@95547fc for premium geo DB SDK methods
lohanidamodar 67566db
Revert "chore: keep @appwrite.io/console@95547fc for premium geo DB S…
lohanidamodar e5a62c5
Merge remote-tracking branch 'origin/main' into feat/project-premium-…
lohanidamodar a54c530
chore: update console SDK to 352239b
lohanidamodar 4376702
merge main
lohanidamodar da68f75
Merge remote-tracking branch 'origin/main' into feat/project-premium-…
lohanidamodar 0889ace
feat(settings): rewrite Premium Geo DB card description to focus on d…
lohanidamodar 6fbdd43
feat(settings): tighten Premium Geo DB card copy to outcome-focused v…
lohanidamodar 1ba8ebd
Merge remote-tracking branch 'origin/main' into feat/project-premium-…
lohanidamodar f8d2816
chore: update console SDK to 634f110
lohanidamodar afecbd2
Merge remote-tracking branch 'origin/main' into feat/project-premium-…
lohanidamodar 60838e0
fix(settings): handle 3DS redirect + replace cancel/retry with refres…
lohanidamodar 279737d
Merge remote-tracking branch 'origin/main' into feat/project-premium-…
lohanidamodar 51ad756
fix: rename Models.Locale to Models.CloudLocale after SDK bump
lohanidamodar bd9d958
Merge main into feat/project-premium-geo-db-addon
lohanidamodar 5b1b4fd
Bump console SDK to @2642dc5 (current cloud HEAD)
lohanidamodar 0983d4c
Bump console SDK to @dd8e255
lohanidamodar bdf38af
Merge remote-tracking branch 'origin/main' into feat/project-premium-…
lohanidamodar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The top-level
addonssection (line 252–275) already creates a billing row for everyaddon_-prefixed resource found incurrentAggregation.resources. If the billing API also surfaces those same addon resources insideprojectData.resources(the per-project breakdown), each project-scoped addon (e.g. Premium Geo DB) will appear as both a top-level line item and a child row — showing the same charge twice to the user.Before shipping, confirm whether the cloud billing API places project-level addon charges exclusively in
breakdown[].resources(making the top-level filter skip them) or in both places. If the former, this code is correct; if the latter, the top-leveladdonsfilter needs to exclude resources that are already accounted for at the project level (or vice-versa).