Skip to content

Add Thunderbird add-on badge service#11918

Open
ankey05 wants to merge 7 commits into
badges:masterfrom
ankey05:add-thunderbird-badge
Open

Add Thunderbird add-on badge service#11918
ankey05 wants to merge 7 commits into
badges:masterfrom
ankey05:add-thunderbird-badge

Conversation

@ankey05

@ankey05 ankey05 commented Jun 9, 2026

Copy link
Copy Markdown

Description

Adds support for Thunderbird add-on badges by implementing a new Thunderbird service based on the existing Mozilla Add-ons integration.

This service retrieves add-on metadata from Thunderbird Add-ons and exposes badge endpoints for Thunderbird extensions.

Motivation

Thunderbird extension developers should be able to display Shields.io badges for their add-ons, similar to the existing Mozilla Add-ons badges.

Closes #6994

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor
Warnings
⚠️

This PR modified service code.
Please run tests by including affected services in the pull request title.

Messages
📖 ✨ Thanks for your contribution to Shields, @ankey05!

Generated by 🚫 dangerJS against a798641

ankey05 added 3 commits June 10, 2026 09:22
- Implement base service for Thunderbird add-ons API
- Add rating/stars badge service with tests
- Add downloads badge service with tests
- Include proper test coverage for all services
@PyvesB

PyvesB commented Jun 13, 2026

Copy link
Copy Markdown
Member

Hello @ankey05 👋🏻

Worth noting that there is an existing PR (#11808) that aims to address the same issue. I'd say the approach you took here with a brand new route probably makes more sense. Could you please remove the legacy/redirect code, it does not make sense for a brand new badge.

@PyvesB PyvesB added the service-badge New or updated service badge label Jun 13, 2026
@ankey05

ankey05 commented Jun 14, 2026

Copy link
Copy Markdown
Author

Thank you for the feedback!

You're absolutely right. I'll remove the legacy redirect code
since it doesn't make sense for a brand new badge service.
I'll keep only the clean Thunderbird implementation without
any redirect or retired service patterns.

I'll push the updated changes shortly and let me know if
there's anything else that needs adjustment.

Thanks for reviewing this!

ankey05 added 3 commits June 14, 2026 14:10
- Removed ThunderbirdLegacyRedirect constant from downloads service
- Removed deprecated badge test from downloads tester
- Kept only clean Thunderbird implementation
- Addresses maintainer feedback on PR badges#11918
- Fixed formatting issues in Thunderbird services
- Prettier auto-fix applied
- Added pathParams import from index.js
- Fixes ESLint error for undefined variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

service-badge New or updated service badge

Development

Successfully merging this pull request may close these issues.

Mozilla Thunderbird add-ons (ATN)

2 participants