fix(coding-agent): wrap long error and prevent URL clipping#3161
Draft
igasmi wants to merge 4 commits into
Draft
fix(coding-agent): wrap long error and prevent URL clipping#3161igasmi wants to merge 4 commits into
igasmi wants to merge 4 commits into
Conversation
getWrappedPreviewLines appended a " …" overflow marker by truncating the final retained line to wrapWidth. When that line was a full-width token — e.g. an account-verification URL wrapped onto its own line — the marker severed the very URL the wrapping was meant to preserve. Make the marker best-effort: append it only when it fits without clipping the retained line; otherwise leave the line intact (full text is still kept in the persisted session). Drop the now-unused `ellipsis` parameter. Adds tests for the full-width-URL case and tightens the overflow-marker test to the marker-has-room path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issues with long turn-ending provider error lines in the terminal TUI: