Add frm operands to float/double instructions#2972
Open
moste00 wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@Rot127 please review. |
moste00
force-pushed
the
fix/frm_operand_in_float_instructions
branch
3 times, most recently
from
51f5f99 to
2ea9114
Compare
Rot127
requested changes
Jun 20, 2026
Rot127
left a comment
Rot127
left a comment
Collaborator
There was a problem hiding this comment.
Please document it in the v6 guide.
moste00
force-pushed
the
fix/frm_operand_in_float_instructions
branch
from
2ea9114 to
5d4894a
Compare
moste00
force-pushed
the
fix/frm_operand_in_float_instructions
branch
from
5d4894a to
6f02d7a
Compare
Contributor
Author
|
@Rot127 done, sorry for the inconsistency of the test comparison, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
I previously ignored FRM operands in float/double instructions because I misjudged them as unnecessary.
However, FRM operands turned out to be important especially when stress-testing float/double instructions with different rounding modes.
Test plan
Added some fields to two existing details test.
Closing issues