revert "feat: nimbus build target"#31763
Conversation
This reverts commit 3b5bc80.
MohamedH1998
requested review from
a team,
MattieTK,
ahaywood,
ay-cf,
colbywhite,
danielegm,
elithrar,
hsaxenaCF,
irvinebroque,
kodster28,
mvvmm,
vs-mg and
vy-ton
as code owners
Review
Code ReviewThis code review is in beta and may not always be helpful — use your judgment. Warnings (1)
ConventionsChecks PR title, description, and redirect checklist. No convention issues found. Style Guide ReviewSuggestions (1)
RedirectsNo missing redirect entries found. CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
github-actions
Bot
added
product:workers
github-actions
Bot
assigned
ahaywood,
colbywhite,
kodster28,
mvvmm,
ay-cf,
danielegm,
elithrar and
hsaxenaCF
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
ask-bonk
Bot
added
engineering
![ask-bonk[bot]](https://avatars.githubusercontent.com/in/2454580?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Review: Revert of #31721 (nimbus build target)
This PR reverts the "nimbus build target" feature introduced in #31721 due to excessive build times. It removes the build target, the associated CI workflow, and nimbus-specific dependencies.
Summary
- Deletes 100+ files under and
- Removes , , and related dependencies
- Reverts to a single Starlight build target
- Cleans up , , , and
Issues Flagged
This revert is over-broad. #31721 contained several drive-by fixes that are not related to the nimbus build target and should be preserved. See inline comments for details.
Recommendation
Before merging, this PR should be updated to preserve the unrelated fixes in:
There was a problem hiding this comment.
PR Review: Revert of #31721 (nimbus build target)
This PR reverts the "nimbus build target" feature introduced in #31721 due to excessive build times. It removes the src/nimbus/ build target, the associated CI workflow, and nimbus-specific dependencies.
Summary
- Deletes 100+ files under src/nimbus/ and .nimbus/
- Removes nimbus-docs, satteri, and related dependencies
- Reverts astro.config.ts to a single Starlight build target
- Cleans up .gitignore, .prettierignore, eslint.config.js, and tsconfig.json
Issues Flagged
This revert is over-broad. #31721 contained several drive-by fixes that are not related to the nimbus build target and should be preserved. See inline comments for details.
Recommendation
Before merging, this PR should be updated to preserve the unrelated fixes in:
- src/content/docs/workers/wrangler/configuration.mdx
- src/content/changelog/waf/2026-05-04-waf-release.mdx
- src/styles/table.css
| - .wrangler/ | ||
| - deploy/ | ||
| - config.json | ||
| - dist - index.js - wrangler.jsonc - .wrangler - deploy - config.json |
There was a problem hiding this comment.
Regression: This reverts a legitimate content fix from #31721. The flat, space-separated FileTree format will not render correctly as a nested directory tree. The properly indented multi-line format should be preserved since it is unrelated to the nimbus build target.
| date: 2026-05-04 | ||
| --- | ||
|
|
||
There was a problem hiding this comment.
Style: Reintroduces trailing whitespace on blank lines (lines 6, 8, 10, 12, etc.). #31721 cleaned these up as a drive-by formatting fix. Consider preserving the whitespace cleanup to avoid style guide violations.
| @@ -72,20 +71,6 @@ rule-id button { | |||
| font-weight: 600; | |||
| } | |||
There was a problem hiding this comment.
Visual regression: Removes table border-radius and header-corner rounding styles that were added in #31721. These are purely visual improvements for markdown tables and are unrelated to the nimbus build target. Consider preserving them.
|
Review complete for PR #31763. Labels Applied
What This PR DoesThis is a full revert of #31721 ("feat: nimbus build target"). It removes the parallel
Issues FlaggedThe revert is over-broad. #31721 contained several legitimate drive-by fixes that are unrelated to the nimbus target and are being reverted here as collateral damage. I left inline review comments on the specific lines:
RecommendationBefore merging, the PR should be amended to preserve the fixes in those three files. Only the nimbus-specific additions and deletions should be reverted. |
11 participants
Just incase cos build times are so long
Reverts #31721