-
Notifications
You must be signed in to change notification settings - Fork 15.4k
Clarify Keyless SSL certificates and add DNS-only key server note #31788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
baubuchon-cf
wants to merge
2
commits into
production
Choose a base branch
from
keyless-cert-clarity
base: production
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+23
−0
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -37,6 +37,29 @@ As a security measure, you should hide the hostname of your key server. | |||||
|
|
||||||
| ::: | ||||||
|
|
||||||
| :::note | ||||||
|
|
||||||
| If your key server hostname is on a zone you have on Cloudflare, you must create a **DNS-only** (grey-clouded) record for it — do not proxy it. If the record is proxied or missing, Cloudflare's edge resolver returns `NXDOMAIN` and the Keyless TLS handshake fails. The fix is the DNS-only record — not adding the hostname to a certificate SAN. | ||||||
|
|
||||||
| ::: | ||||||
|
|
||||||
| --- | ||||||
|
|
||||||
| ## Certificates used in Keyless SSL | ||||||
|
|
||||||
| Keyless SSL involves **two different certificates**. Confusing them is the most common setup error. | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Define the acronym before it appears in the table below:
Suggested change
|
||||||
|
|
||||||
| | Certificate | What it is | SAN should contain | | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Expand the acronym for accessibility:
Suggested change
|
||||||
| | --- | --- | --- | | ||||||
| | **Edge (Keyless SSL) certificate** | The public certificate Cloudflare serves for your site. | Your site hostnames only (for example, `www.example.com`) | | ||||||
| | **Key server authentication certificate** | The certificate your key server uses to prove itself to Cloudflare. | The key server hostname only | | ||||||
|
|
||||||
| :::caution | ||||||
|
|
||||||
| Do **not** add your key server hostname to the SAN of your public edge certificate. It is not required, and it leaks internal hostnames into the public certificate and Certificate Transparency logs. | ||||||
|
|
||||||
| ::: | ||||||
|
|
||||||
| --- | ||||||
|
|
||||||
| ## 2. Upload Keyless SSL Certificates | ||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.