Implementing the TODO in pingora-core rustls listener to avoid panics by returning a Result#928
Conversation
There was a problem hiding this comment.
Seems like this can still panic here vs. returning the Err?
There was a problem hiding this comment.
Likewise, if we're going to change the API here anyhow, we should translate these panics into Errs as well.
There was a problem hiding this comment.
Right, I was waiting for some feedback before changing this. I wanted to confirm whether those panics were intentional or if they should be changed as well before updating this and a few other panic!/unwrap() calls. Commits coming soon. Thanks for the feedback!
|
Working on these still - mb for pushing - these currently fail with |
|
this should be working now since |
|
Hey! Just following up...let me know if I need to make any further changes :) Thanks! |
Fixes #927
All tests pass with
cargo test -p pingora-core