fix(ui): fix Select keyboard navigation — first arrow key press now highlights first item#1798
Draft
franzheidl wants to merge 1 commit into
Draft
fix(ui): fix Select keyboard navigation — first arrow key press now highlights first item#1798franzheidl wants to merge 1 commit into
franzheidl wants to merge 1 commit into
Conversation
…ocuses first menu item Only mount portal when menu is open so headless sorts items in the actual rendered dom Signed-off-by: Franz Heidl <f.heidl@sap.com>
|
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Dropdown options were always mounted in the DOM, hidden via
display: noneon the Floating UI container. Headless UI's DOM-order sort ran against
elements in a hidden subtree on page load, producing an unreliable option
order. On first open,
goToOptioncouldn't resolve the correct active indexand the first few arrow-down presses had no visible effect.
Fix
{open && createPortal(...)})so options mount, register, and sort against visible DOM elements
SelectOptionfromas={Fragment}toas="li"so HUI owns theelement and sets
data-activenativelytabIndex={-1}to the floating container to exclude it from sequentialkeyboard focus order
Closes #1781
Test plan
Checklist
PR Manifesto
Review the PR Manifesto for best practises.