Skip to content

Exposure Module: Tooltip change + Comment overhaul #21472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anoderay wants to merge 2 commits into
base: master
Choose a base branch
from
+4 −9
Open

Exposure Module: Tooltip change + Comment overhaul #21472

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
437df52
Remove tooltip mention of tonemapper for highlight preservation module
anoderay Jul 1, 2026
2b2c543
update comment to reference exif.cc
anoderay Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions src/iop/exposure.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,11 +585,9 @@ static float _get_highlight_bias(const dt_iop_module_t *self)
{
float bias = 0.0f;

// Nikon: Exif.Nikon3.Colorspace==4 --> +2 EV
// Fuji: Exif.Fujifilm.DevelopmentDynamicRange
// 100 --> no comp
// 200 --> +1 EV
// 400 --> +2 EV
// exif_highlight_preservation holds the exposure (EV) that the camera withheld
// in an HDR / dynamic-range / HLG tone mode; so we compensate for it in exposure.
// Per-camera detection happens in _check_highlight_preservation() in common/exif.cc.

if(self->dev && self->dev->image_storage.exif_highlight_preservation > 0.0f)
bias = self->dev->image_storage.exif_highlight_preservation;
Expand Down Expand Up @@ -1203,10 +1201,7 @@ void gui_init(dt_iop_module_t *self)
(self, "compensate_hilite_pres");
gtk_widget_set_tooltip_text(g->compensate_hilite_preserv,
_("remove the camera's hidden exposure bias in\n"
"HDR / highlight preservation / dynamic range / HLG tone mode.\n"
"\n"
"when enabled on an image with nonzero bias, tone mapping\n"
"(e.g. sigmoid) is required to avoid blown-out highlights."));
"HDR / highlight preservation / dynamic range / HLG tone mode.\n"));

g->exposure = dt_color_picker_new(self, DT_COLOR_PICKER_AREA,
dt_bauhaus_slider_from_params(self, N_("exposure")));
Expand Down
Loading