Show warning on 4BAYER raw denoise preview#21481
Open
andriiryzhkov wants to merge 1 commit into
Open
Conversation
andriiryzhkov
added
bugfix
Member
|
This is introducing a new string, not good to 5.6.1. |
Collaborator
Author
|
OK. It could be postponed to 5.8 then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to kofa's review on #21463.
For 4BAYER (CYGM/RGBE) raws, the preview's re-mosaic step has no RGB→CFA mapping – the model runs but its output can't be written back into the mosaic buffer, so before and after look identical in the split view. kofa flagged this: user sees "before / after look the same" and doesn't know why.
Batch processing still works – it uses a demosaic-then-denoise path that writes a Linear DNG directly, no re-mosaic needed. So the preview is the only broken bit.
Fix: red warning bar at the top of the preview for 4BAYER images, using the same mechanism the upscale task uses for "large output" warnings. Text:
preview unavailable – process to save result.