backport: Merge bitcoin#26642, 27344, gui#726, 27465, 26207, 27468

[vijaydasmp]

bitcoin back ports

[github-actions]

⚠️ Potential Merge Conflicts Detected

This PR has potential conflicts with the following open PRs:

• backport: bitcoin#18933, #23123, #23147, #23549, #26074, #26207, #26307, #26341, #26352, #26656, #26886, #26996, #27035 #7192 - backport: bitcoin#18933, #23123, #23147, #23549, #26074, #26207, #26307, #26341, #26352, #26656, #26886, #26996, #27035

Please coordinate with the authors of these PRs to avoid merge conflicts.

[thepastaclaw]

✅ Review complete (commit 0e96447)

[coderabbitai]

Walkthrough

This PR adds verbose and mempool_sequence query parameters to the REST mempool contents endpoint with validation, wraps count parameter parsing in try/catch across REST handlers, makes httpserver.cpp throw on failed URI parsing (with matching unit/functional tests), removes a legacy numeric-parsing compatibility layer from the string fuzz target, and applies numerous std::vector::reserve() preallocation additions across production and test code, plus minor literal-to-character search changes and documentation/config wording updates.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Client
  participant RestHandler as rest_mempool
  participant MempoolToJSON

  Client->>RestHandler: GET /rest/mempool/contents.json?verbose&mempool_sequence
  RestHandler->>RestHandler: parse/validate query params
  alt invalid or conflicting params
    RestHandler-->>Client: HTTP_BAD_REQUEST
  else valid params
    RestHandler->>MempoolToJSON: verbose, mempool_sequence
    MempoolToJSON-->>RestHandler: JSON result
    RestHandler-->>Client: JSON response
  end

Loading

sequenceDiagram
  participant Client
  participant HTTPServer as httpserver.cpp
  participant evhttp_uri_parse

  Client->>HTTPServer: request with invalid URI
  HTTPServer->>evhttp_uri_parse: parse(uri)
  evhttp_uri_parse-->>HTTPServer: nullptr
  HTTPServer-->>Client: throw std::runtime_error / HTTP 400

Loading

Suggested reviewers: thepastaclaw, knst, PastaPastaPasta

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	The description is related to the changeset, but it is too generic to convey meaningful detail.	Replace it with a brief summary of the backported fixes, such as REST changes, lint updates, and fuzz test cleanup.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately reflects that this is a backport merge of specific Bitcoin PRs.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

🧹 Nitpick comments (1)

src/rest.cpp (1)

656-679: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Duplicate boolean-parsing boilerplate for verbose/mempool_sequence.

The two query-parameter blocks (fetch → validate "true"/"false" → 400 on error) are structurally identical aside from the parameter name and default. Extracting a small helper (e.g. ParseBoolQueryParam(req, name, default) -> std::optional<bool-or-error>) would remove duplication and make future boolean query params easier to add.

♻️ Example helper sketch

+static util::Result<bool> GetBoolQueryParam(HTTPRequest* req, const std::string& name, bool default_value)
+{
+    std::string raw;
+    try {
+        raw = req->GetQueryParameter(name).value_or(default_value ? "true" : "false");
+    } catch (const std::runtime_error& e) {
+        return util::Error{Untranslated(e.what())};
+    }
+    if (raw != "true" && raw != "false") {
+        return util::Error{Untranslated(strprintf("The \"%s\" query parameter must be either \"true\" or \"false\".", name))};
+    }
+    return raw == "true";
+}

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/rest.cpp` around lines 656 - 679, The `verbose` and `mempool_sequence`
query-parameter handling in `src/rest.cpp` duplicates the same
fetch/validate/400-error flow twice. Refactor this into a small reusable helper
near the request parsing logic used by `MempoolToJSON`, so both parameters are
parsed through one path that accepts the parameter name and default, validates
only "true"/"false", and returns the boolean value or error consistently.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@src/rest.cpp`:
- Around line 656-679: The `verbose` and `mempool_sequence` query-parameter
handling in `src/rest.cpp` duplicates the same fetch/validate/400-error flow
twice. Refactor this into a small reusable helper near the request parsing logic
used by `MempoolToJSON`, so both parameters are parsed through one path that
accepts the parameter name and default, validates only "true"/"false", and
returns the boolean value or error consistently.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 120e3388-19ce-4e35-8597-bf0c5d9aabb8

📥 Commits

Reviewing files that changed from the base of the PR and between 4af395d and 0e96447.

📒 Files selected for processing (31)

• ci/dash/lint-tidy.sh
• doc/REST-interface.md
• doc/developer-notes.md
• src/.clang-tidy
• src/bench/lockedpool.cpp
• src/bitcoin-cli.cpp
• src/bitcoin-util.cpp
• src/httpserver.cpp
• src/node/interfaces.cpp
• src/qt/trafficgraphwidget.cpp
• src/rest.cpp
• src/rpc/server.cpp
• src/rpc/util.cpp
• src/test/allocator_tests.cpp
• src/test/fuzz/string.cpp
• src/test/fuzz/tx_pool.cpp
• src/test/getarg_tests.cpp
• src/test/httpserver_tests.cpp
• src/test/policyestimator_tests.cpp
• src/test/scheduler_tests.cpp
• src/test/script_p2sh_tests.cpp
• src/test/util/net.cpp
• src/test/util_threadnames_tests.cpp
• src/test/validation_block_tests.cpp
• src/util/bip32.cpp
• src/wallet/bdb.cpp
• src/wallet/rpc/backup.cpp
• src/wallet/scriptpubkeyman.cpp
• src/zmq/zmqpublishnotifier.cpp
• test/functional/interface_rest.py
• test/lint/lint-locale-dependence.py

💤 Files with no reviewable changes (1)

• test/lint/lint-locale-dependence.py

[thepastaclaw]

Code Review

I verified the two parsed Codex findings against the checked-out PR. The REST docs still carry Bitcoin Core's "25.0 and up" release note even though this Dash tree is versioned as 23.1.5, so that is a real in-scope documentation issue. The GUI provenance claim does not hold: the trafficgraphwidget change is part of the listed upstream bitcoin#26642 commit, while bitcoin-core/gui#726 is a different AddressPurpose change.

💬 1 nitpick(s)

Source: reviewers: gpt-5.5 (general, dash-core-commit-history); failed lanes: opus/claude-sonnet-5 (general, dash-core-commit-history, backport-reviewer), gpt-5.5 (backport-reviewer); verifier: gpt-5.5.

[thepastaclaw]

💬 Nitpick: Remove Bitcoin Core release number from Dash REST docs

This note was copied from the Bitcoin Core backport and says the new verbose and mempool_sequence query parameters are available in 25.0 and up. This is Dash Core documentation, and this PR is based on a Dash tree reporting version 23.1.5 in configure.ac, so the Bitcoin Core release number is misleading for Dash users trying to determine which Dash release contains /rest/mempool/contents.json?verbose=...&mempool_sequence=.... Adapt the sentence to the Dash release that will ship this backport, or remove the version-specific sentence.

_{source: ['codex']}