Feat async extended matchers#7213
Open
lowlighter wants to merge 3 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7213 +/- ##
=======================================
Coverage 94.84% 94.84%
=======================================
Files 617 618 +1
Lines 51674 51690 +16
Branches 9350 9355 +5
=======================================
+ Hits 49008 49024 +16
Misses 2121 2121
Partials 545 545 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows extended matchers in
expectto return eitherExtendMatchResultorPromise<ExtendMatchResult>This changes provides additional possibilities for custom matchers, like implementing a
expect(value).toBeResolved()matcher.Example:
This is just an example, but it can be used for any custom matcher that requires async operations on the right side
(for example one could image matching agains dynamically fetched files, database query results, etc.)
Side note: While this PR doesn't address specifically the following issues, the example (in the diff of the test file) shows how to implement a matcher to test promise states
assertPromiseResolved()#3759promiseState()to@std/async#5727This is a reopen of #6806, i mistakenly closed it by deleting my fork