Fix grpc-core ServerListener.transportCreated drop breaking Firestore Java builds#1490
Open
Copilot wants to merge 2 commits into
Open
Fix grpc-core ServerListener.transportCreated drop breaking Firestore Java builds#1490Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
…fixes grpc-core Java build) Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix Xamarin.Firebase.Firestore build failure on .NET 9 Android
Fix grpc-core ServerListener.transportCreated drop breaking Firestore Java builds
Jun 29, 2026
There was a problem hiding this comment.
Pull request overview
This PR fixes a gRPC binding-generation mismatch where io.grpc.internal.ServerListener.transportCreated(ServerTransport) was being silently dropped (due to an unbound ServerTransport type), causing the generated ServerListenerImplementor.java to miss an override and break downstream Android app Java compilation (e.g., via Xamarin.Firebase.Firestore → Xamarin.Grpc.Core).
Changes:
- Reintroduces a minimal
io.grpc.internal.ServerTransportinterface in metadata sotransportCreated(ServerTransport)can be bound again. - Re-adds
ServerListener.transportCreated(...)to keep the managed interface and generated Java implementor in sync. - Bumps
Xamarin.Grpc.CoreNuGet revision and updates PublicAPI unshipped surface to include the restored API.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| source/io.grpc/grpc-core/Transforms/Metadata.xml | Adds minimal ServerTransport and restores ServerListener.transportCreated(...) so the *Implementor compiles correctly. |
| source/io.grpc/grpc-core/PublicAPI/PublicAPI.Unshipped.txt | Reflects the new/restored public API surface (IServerTransport, TransportCreated, related delegate). |
| config.json | Bumps Xamarin.Grpc.Core nugetVersion to publish the binding fix as a new revision. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apps referencing
Xamarin.Firebase.Firestore(transitivelyXamarin.Grpc.Core) fail to build withServerListenerImplementor is not abstract and does not override abstract method transportCreated(ServerTransport) in ServerListener.Root cause
io.grpc.internal.ServerListenerhas two abstract methods,serverShutdown()andtransportCreated(ServerTransport). The latter was silently dropped because its parameterio.grpc.internal.ServerTransportis unbound —ServerTransport implements io.grpc.InternalInstrumented, which is itself dropped (itsgetStats()returns an unbound GuavaListenableFuture). SinceServerListeneris a*Listener, the generator emits anIServerListenerImplementorACW (mono/io/grpc/internal/ServerListenerImplementor.java); withtransportCreatedmissing, the ACW overrode onlyserverShutdown()and failed Java compilation in consumers.Changes
source/io.grpc/grpc-core/Transforms/Metadata.xml<add-node>a minimalio.grpc.internal.ServerTransportinterface (its three directly-declared methods, omitting the unboundInternalInstrumentedbase) so the parameter type resolves.<add-node>transportCreatedback ontoServerListener.config.json— bumpXamarin.Grpc.CorenugetVersion1.82.0.1→1.82.0.2.PublicAPI.Unshipped.txt— regenerated: addsIServerTransport,IServerListener.TransportCreated,ServerTransportCreatedHandler.ServerTransportis not a*Listener, so it gets no Implementor of its own — the minimal stub adds no new ACW and cannot reintroduce a missing-override break.The generated implementor now overrides both methods: