fix: remove the library retain logic - #213
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the global CEF lifecycle management in gdcef to avoid attempting a shutdown/reinitialize cycle within the same process, addressing the macOS crash reported in #212 when destroying the last CefTexture and creating a new one later.
Changes:
- Make CEF initialization effectively “one-time per process” by keying init on an
initializedflag rather thanref_count == 0. - Remove the “shutdown on last release” behavior so later
cef_retain()calls don’t need to reload/reinitialize CEF. - Add a unit test asserting that releasing the last reference keeps CEF marked initialized.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
78
to
81
| pub fn cef_release() { | ||
| let mut state = lock_cef_state(); | ||
|
|
||
| if state.ref_count == 0 { | ||
| return; | ||
| } | ||
|
|
||
| state.ref_count -= 1; | ||
|
|
||
| if state.ref_count == 0 && state.initialized { | ||
| cef::shutdown(); | ||
| state.initialized = false; | ||
| } | ||
| state.release(); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #212