Skip to content

Fix get_client_filters livelock in protocol_filter_out_70015 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
echennells wants to merge 1 commit into from
Closed

Fix get_client_filters livelock in protocol_filter_out_70015 #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/protocols/protocol_filter_out_70015.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ bool protocol_filter_out_70015::handle_receive_get_filters(const code& ec,

span<milliseconds>(events::ancestry_msecs, start);
send_filter(error::success, ancestry);
return false;
return true;
}

void protocol_filter_out_70015::send_filter(const code& ec,
Expand All @@ -233,11 +233,7 @@ void protocol_filter_out_70015::send_filter(const code& ec,
return;

if (ancestry->empty())
{
// Complete, resubscribe to get_client_filters.
SUBSCRIBE_CHANNEL(get_client_filters, handle_receive_get_filters, _1, _2);
return;
}

const auto& query = archive();
const auto start = logger::now();
Expand Down
Loading