Skip to content

xds mux: harden queueing#45832

Open
kyessenov wants to merge 1 commit into
envoyproxy:mainfrom
kyessenov:fix_shutdown_queue
Open

xds mux: harden queueing#45832
kyessenov wants to merge 1 commit into
envoyproxy:mainfrom
kyessenov:fix_shutdown_queue

Conversation

@kyessenov

Copy link
Copy Markdown
Contributor

Change-Id: I83367169d4e37e14370d1dd764e1baef052e27c9

Commit Message: Harden shutdown sequence to early exit and not queue xDS requests.
Additional Description:
Risk Level: low
Testing: detected in my local integration test run
Docs Changes:
Release Notes: none

Change-Id: I83367169d4e37e14370d1dd764e1baef052e27c9
Signed-off-by: Kuat Yessenov <kuat@google.com>

@adisuissa adisuissa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
Double checked that it's already done in the unified-mux and the delta-xDS implementations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants