-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
docs: add Deno to the package manager tabs #2395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bartlomieju
wants to merge
7
commits into
expressjs:main
Choose a base branch
from
bartlomieju:add-deno-package-manager
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
185e83a
docs: add Deno to the package manager tabs
bartlomieju 4c753ee
Use deno x and deno create --npm for exec/create mappings
bartlomieju 70945e5
Address review: deno install -g for global, simplify npx mapping
bartlomieju aa20426
Drop comment on deno install case for consistency with other managers
bartlomieju 5a60f34
Address review: map global uninstall to deno uninstall --global
bartlomieju 6d9e576
Use deno uninstall for removals (handles --global)
bartlomieju 1d743b8
Merge branch 'main' into add-deno-package-manager
bjohansebas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure that Deno allows uninstalling packages installed globally.
BTW Deno docs say that
addis an alias ofinstallandremoveis an alias ofuninstall, but aliases usually accept the same parameters.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the catch, actually it looks like
deno removedoesn't accept--global. I'll fix it for Deno v2.9 and can open a follow up PR once it lands if that works for you.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thanks! Fixed β global removals now map to
deno uninstall --global <pkg>(mirroring theyarn global removebranch) instead of being dropped. You're right thatremove/uninstallare aliases, but onlyuninstalltakes--global, so I used that for the global case.