Skip to content

refactor(parquet): Fix comment formatting and order of files in cmake #17586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mohsaka wants to merge 1 commit into from
Closed

refactor(parquet): Fix comment formatting and order of files in cmake #17586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion velox/dwio/parquet/common/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@
velox_add_library(
velox_dwio_parquet_common
BloomFilter.cpp
XxHasher.cpp
LevelComparison.cpp
LevelConversion.cpp
XxHasher.cpp
HEADERS
BitStreamUtilsInternal.h
BloomFilter.h
Expand Down
2 changes: 1 addition & 1 deletion velox/dwio/parquet/writer/arrow/ColumnWriter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ class TypedColumnWriter : public ColumnWriter {
int64_t validBitsOffset,
const T* values) = 0;

// Estimated size of the values that are not written to a page yet
// Estimated size of the values that are not written to a page yet.
virtual int64_t estimatedBufferedValueBytes() const = 0;
};

Expand Down
8 changes: 4 additions & 4 deletions velox/dwio/parquet/writer/arrow/FileWriter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,11 @@ class PARQUET_EXPORT RowGroupWriter {
virtual int currentColumn() const = 0;
virtual void close() = 0;

/// \brief Total uncompressed bytes written by the page writer
/// \brief Total uncompressed bytes written by the page writer.
virtual int64_t totalBytesWritten() const = 0;
/// \brief Total bytes still compressed but not written by the page writer
/// \brief Total bytes still compressed but not written by the page writer.
virtual int64_t totalCompressedBytes() const = 0;
/// \brief Total compressed bytes written by the page writer
/// \brief Total compressed bytes written by the page writer.
virtual int64_t totalCompressedBytesWritten() const = 0;

virtual bool buffered() const = 0;
Expand Down Expand Up @@ -98,7 +98,7 @@ class PARQUET_EXPORT RowGroupWriter {
/// \brief Total bytes still compressed but not written by the page writer.
/// It will always return 0 from the SerializedPageWriter.
int64_t totalCompressedBytes() const;
/// \brief Total compressed bytes written by the page writer
/// \brief Total compressed bytes written by the page writer.
int64_t totalCompressedBytesWritten() const;
/// Returns whether the current RowGroupWriter is in the buffered mode and is
/// created by calling ParquetFileWriter::appendBufferedRowGroup().
Expand Down
Loading
Loading