Align threshold linters with sibling analyzer behavior

[Copilot]

excessivefuncparams was the only FuncDecl-based linter still analyzing _test.go, and neither excessivefuncparams nor largefunc supported per-site //nolint suppression. That made both threshold linters noisy in tests and hard to enforce without weakening global limits.

• Analyzer behavior

  • excessivefuncparams now skips _test.go, matching the existing behavior of sibling FuncDecl linters.
  • excessivefuncparams now honors //nolint:excessivefuncparams.
  • largefunc now honors //nolint:largefunc.

• Implementation shape

  • Wired both analyzers to the shared internal/nolint helpers (BuildLineIndex / HasDirective) used elsewhere in pkg/linters.
  • Gated reports on the resolved source position so threshold violations can be suppressed at the declaration site without changing analyzer-wide thresholds.

• Analysistest coverage

  • Added a _test.go fixture for excessivefuncparams to assert test helpers are ignored.
  • Added suppression fixtures for both analyzers to assert //nolint prevents diagnostics while unsuppressed cases still report.

//nolint:excessivefuncparams
func suppressedTooManyParams(a, b, c, d, e, f, g, h, i int) {}

//nolint:largefunc
func suppressedLargeFunc() {
	// body intentionally over threshold
}

[Copilot]

Pull request overview

Note

Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.

Aligns the excessivefuncparams and largefunc threshold linters with other FuncDecl-based analyzers by reducing noise in _test.go and enabling per-declaration //nolint suppression.

Changes:

• Skip _test.go files in excessivefuncparams to match sibling analyzers’ behavior.
• Add //nolint:<linter> directive support for both excessivefuncparams and largefunc via shared internal/nolint helpers.
• Extend analysistest fixtures to cover _test.go skipping and suppression behavior.

Show a summary per file

File	Description
pkg/linters/largefunc/largefunc.go	Adds nolint directive handling and uses source positions for suppression and test-file skipping.
pkg/linters/largefunc/testdata/src/a/a.go	Adds a suppressed large function fixture to validate //nolint:largefunc.
pkg/linters/excessivefuncparams/excessivefuncparams.go	Skips _test.go and adds nolint suppression for excessive parameter diagnostics.
pkg/linters/excessivefuncparams/testdata/src/a/a.go	Adds a suppressed excessive-params fixture to validate //nolint:excessivefuncparams.
pkg/linters/excessivefuncparams/testdata/src/a/a_test.go	Adds a _test.go fixture to ensure the analyzer ignores test helpers.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 5/5 changed files
• Comments generated: 2