fix(seenmapbool): eliminate duplicate diagnostics for set-maps in closures

[Copilot]

seenmapbool emitted the same map[string]bool diagnostic N+1 times for a set-map declared N levels deep in closures. The first ast.Inspect pass in inspectBody recursed into nested *ast.FuncLit bodies, so each closure's maps were collected by both the enclosing function's pass and the closure's own Preorder-triggered pass.

Changes

• pkg/linters/seenmapbool/seenmapbool.go — first ast.Inspect pass now returns false on *ast.FuncLit, stopping recursion at closure boundaries. The second (write-disqualification) pass still recurses into closures so that a non-true write inside a closure correctly disqualifies an outer-scoped map candidate.

• testdata/src/seenmapbool/seenmapbool.go — three new cases:

  • BadSetBoolInClosure / BadSetBoolInNestedClosure — assert exactly one // want at 1- and 2-level nesting
  • GoodOuterMapWrittenFalseInClosure — outer map written false in closure, must not be reported (guards the second-pass recursion)

func Dedup(xs []string) []string {
    unique := func(in []string) []string {
        seen := make(map[string]bool) // reported once, not twice
        // ...
    }
    return unique(xs)
}

[Copilot]

Pull request overview

Note

Copilot couldn't run its full agentic review because no GitHub Actions runner was available. Make sure your repository has a runner available to run Copilot's review, or add a copilot-setup-steps.yml file specifying one with the runs-on attribute. See the docs for more details.

Fixes duplicate map[string]bool “used as a set” diagnostics when a set-map is declared inside nested closures by preventing the initial candidate-collection traversal from descending into *ast.FuncLit bodies.

Changes:

• Stop the first ast.Inspect pass at *ast.FuncLit boundaries to avoid re-collecting closure-local candidates from outer traversals.
• Add test cases covering 1- and 2-level closure nesting (should report once) and verifying that a false write inside a closure disqualifies an outer-scoped map.

Show a summary per file

File	Description
pkg/linters/seenmapbool/seenmapbool.go	Prevents duplicate diagnostics by halting the first traversal at closure boundaries.
pkg/linters/seenmapbool/testdata/src/seenmapbool/seenmapbool.go	Adds regression tests for closure nesting and disqualification via writes inside closures.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 2/2 changed files
• Comments generated: 2