Skip to content

[code-scanning-fix] Fix workflow-graphql-id-unescaped: eliminate string interpolation in GraphQL mutations via variables #40757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
github-actions wants to merge 2 commits into
base: main
Choose a base branch
from
+23 −10
Open

[code-scanning-fix] Fix workflow-graphql-id-unescaped: eliminate string interpolation in GraphQL mutations via variables #40757

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c4b872
fix: escape GraphQL string interpolation in project mutations (CWE-89)
github-actions[bot] Jun 22, 2026
c969477
refactor: use GraphQL variables in project mutations to eliminate str…
Copilot Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 23 additions & 10 deletions pkg/cli/project_command.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,18 +291,22 @@ func createProject(ctx context.Context, ownerId, title string, verbose bool) (ma
projectLog.Printf("Creating project: ownerId=%s, title=%s", ownerId, title)
console.LogVerbose(verbose, "Creating project with owner ID: "+ownerId)

mutation := fmt.Sprintf(`mutation {
createProjectV2(input: { ownerId: "%s", title: "%s" }) {
mutation := `mutation($ownerId: ID!, $title: String!) {
createProjectV2(input: { ownerId: $ownerId, title: $title }) {
projectV2 {
id
number
title
url
}
}
}`, ownerId, escapeGraphQLString(title))
}`

output, err := workflow.RunGH("Creating project...", "api", "graphql", "-f", "query="+mutation)
output, err := workflow.RunGH("Creating project...", "api", "graphql",
"-f", "query="+mutation,
"-f", "ownerId="+ownerId,
"-f", "title="+title,
)
if err != nil {
// Check for permission errors
//nolint:errstringmatch // gh CLI GraphQL surfaces missing Projects scope as INSUFFICIENT_SCOPES text.
Expand Down Expand Up @@ -352,8 +356,13 @@ func linkProjectToRepo(ctx context.Context, projectId, repoSlug string, verbose
repoName := parts[1]

// Get repository ID
query := fmt.Sprintf(`query { repository(owner: "%s", name: "%s") { id } }`, escapeGraphQLString(repoOwner), escapeGraphQLString(repoName))
output, err := workflow.RunGH("Getting repository ID...", "api", "graphql", "-f", "query="+query, "--jq", ".data.repository.id")
repoIdQuery := `query($owner: String!, $name: String!) { repository(owner: $owner, name: $name) { id } }`
output, err := workflow.RunGH("Getting repository ID...", "api", "graphql",
"-f", "query="+repoIdQuery,
"-f", "owner="+repoOwner,
"-f", "name="+repoName,
"--jq", ".data.repository.id",
)
if err != nil {
return fmt.Errorf("repository '%s' not found: %w", repoSlug, err)
}
Expand All @@ -364,15 +373,19 @@ func linkProjectToRepo(ctx context.Context, projectId, repoSlug string, verbose
}

// Link project to repository
mutation := fmt.Sprintf(`mutation {
linkProjectV2ToRepository(input: { projectId: "%s", repositoryId: "%s" }) {
mutation := `mutation($projectId: ID!, $repositoryId: ID!) {
linkProjectV2ToRepository(input: { projectId: $projectId, repositoryId: $repositoryId }) {
repository {
id
}
}
}`, projectId, repoId)
}`

_, err = workflow.RunGH("Linking project to repository...", "api", "graphql", "-f", "query="+mutation)
_, err = workflow.RunGH("Linking project to repository...", "api", "graphql",
"-f", "query="+mutation,
"-f", "projectId="+projectId,
"-f", "repositoryId="+repoId,
)
if err != nil {
return fmt.Errorf("failed to link project to repository: %w", err)
}
Expand Down