Skip to content

ci: discover opt Python path dynamically + sync upstream #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gounthar merged 4 commits into from
Apr 26, 2026
Merged

ci: discover opt Python path dynamically + sync upstream #8

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dcb3928
[codex] Pin GitHub Actions workflow references (#515)
hintz-openai Mar 27, 2026
6437cbf
Merge remote-tracking branch 'upstream/main' into fix/rise-runner-pyt…
gounthar Apr 26, 2026
adf49e8
ci: discover opt Python path dynamically on RISE runner
gounthar Apr 26, 2026
9c9a2e9
ci: remove dead-code opt-Python cffi install block
gounthar Apr 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/build-riscv64.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,13 @@ jobs:
# FFI declaration generation. uvx --with cffi covers the tool env
# (Python 3.14); install it separately into the RISE runner's opt
# Python so maturin can generate declarations for that interpreter too.
sudo /opt/python-3.12/bin/python3 -m pip install --quiet cffi
uvx --python 3.14 --with maturin --with setuptools --with cffi maturin build --release --out /tmp/wheels/
# Discover the path dynamically — runner image updates may change the version.
OPT_PYTHON=$(find /opt -maxdepth 3 -name "python3" -type f 2>/dev/null | head -1)
if [ -n "$OPT_PYTHON" ]; then

@gounthar gounthar Apr 26, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The entire OPT_PYTHON block has been removed in the latest commit. Since maturin build runs under uvx --python 3.14, there's no interpreter auto-discovery — the opt-Python cffi install was never exercised. The nondeterminism concern is now moot.

sudo "$OPT_PYTHON" -m pip install --quiet cffi
fi
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
uvx --python 3.14 --with maturin --with setuptools --with cffi maturin build \
--release --out /tmp/wheels/

- name: Verify platform tag
run: |
Expand Down
20 changes: 10 additions & 10 deletions .github/workflows/build_wheels.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,14 @@ jobs:
python-version: [39, 310, 311, 312, 313, 313t, 314, 314t]

steps:
- uses: actions/checkout@v6
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6

- uses: pypa/cibuildwheel@v3.1.4
- uses: pypa/cibuildwheel@65b8265957fd86372d9689a0acdfd55813970d5d # v3.1.4
env:
CIBW_BUILD: "cp${{ matrix.python-version}}-*"
CIBW_ENABLE: cpython-freethreading

- uses: actions/upload-artifact@v6
- uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6
with:
name: cibw-wheels-${{ matrix.os }}-${{ strategy.job-index }}
path: ./wheelhouse/*.whl
Expand All @@ -43,10 +43,10 @@ jobs:
python-version: [39, 310, 311, 312, 313, 313t, 314, 314t]

steps:
- uses: actions/checkout@v6
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6

- name: Build wheels
uses: pypa/cibuildwheel@v3.1.4
uses: pypa/cibuildwheel@65b8265957fd86372d9689a0acdfd55813970d5d # v3.1.4
env:
CIBW_BUILD: "cp${{ matrix.python-version}}-*"
CIBW_ARCHS: aarch64
Expand All @@ -55,7 +55,7 @@ jobs:
CIBW_ENVIRONMENT_LINUX: PATH="$PATH:$HOME/.cargo/bin" CARGO_NET_GIT_FETCH_WITH_CLI=true
CIBW_ENABLE: cpython-freethreading

- uses: actions/upload-artifact@v6
- uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6
with:
name: cibw-wheels-aarch64-${{ matrix.os }}-${{ strategy.job-index }}
path: ./wheelhouse/*.whl
Expand All @@ -65,8 +65,8 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 60
steps:
- uses: actions/checkout@v6
- uses: actions/setup-python@v6
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
- uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6
name: Install Python
with:
python-version: "3.9"
Expand All @@ -78,7 +78,7 @@ jobs:
run: |
pip install --upgrade build
python -m build --sdist
- uses: actions/upload-artifact@v6
- uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6
with:
name: cibw-wheels-${{ matrix.os }}-${{ strategy.job-index }}

@gounthar gounthar Apr 26, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed. build_sdist has no matrix, so both ${{ matrix.os }} and ${{ strategy.job-index }} expand to empty strings — the artifact ends up named cibw-wheels--. This came in via upstream sync, not this branch. Filed a follow-up issue to fix it.

path: ./dist/*.tar.gz
Expand All @@ -89,7 +89,7 @@ jobs:
needs: [build_wheels, build_wheels_aarch64, build_sdist]
steps:
- name: Merge artifacts
uses: actions/upload-artifact/merge@v4
uses: actions/upload-artifact/merge@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4
Comment on lines 90 to +92
with:
name: cibw-wheels
pattern: cibw-wheels-*
Expand Down